'Re: Review Request: avoid 3 clang warnings'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request: avoid 3 clang warnings
From:       "Commit Hook" <null () kde ! org>
Date:       2012-06-03 8:37:28
Message-ID: 20120603083728.5568.77862 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105134/#review14389
-----------------------------------------------------------

This review has been submitted with commit abc765128fd61139d82a895364ce9183=
ffb74454 by Jaime Torres to branch master.

- Commit Hook

On June 2, 2012, 10:51 a.m., Jaime Torres Amate wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105134/
> -----------------------------------------------------------
> =

> (Updated June 2, 2012, 10:51 a.m.)
> =

> =

> Review request for Kate.
> =

> =

> Description
> -------
> =

> Just place {} around if to avoid the compiler to choose the right level o=
f else.
> Use the variable newLineReg (unused ) to do the same just a little faster=
 ( avoid 1 QRegExpresion compilation ).
> =

> =

> Diffs
> -----
> =

>   kate/plugins/katesql/dataoutputmodel.cpp 760f8bb =

>   part/render/katelayoutcache.cpp 2030d07 =

>   part/syntax/katehighlight.cpp c31c634 =

> =

> Diff: http://git.reviewboard.kde.org/r/105134/diff/
> =

> =

> Testing
> -------
> =

> works as before.
> =

> =

> Thanks,
> =

> Jaime Torres Amate
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105134/">http://git.reviewboard.kde.org/r/105134/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit abc765128fd61139d82a895364ce9183ffb74454 by Jaime Torres to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On June 2nd, 2012, 10:51 a.m., Jaime Torres Amate wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated June 2, 2012, 10:51 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Just place {} around if to avoid the compiler to choose the right level \
of else. Use the variable newLineReg (unused ) to do the same just a little faster ( \
avoid 1 QRegExpresion compilation ).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works as before.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/plugins/katesql/dataoutputmodel.cpp <span style="color: \
grey">(760f8bb)</span></li>

 <li>part/render/katelayoutcache.cpp <span style="color: grey">(2030d07)</span></li>

 <li>part/syntax/katehighlight.cpp <span style="color: grey">(c31c634)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105134/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 