[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: yup,   kate's HL code is bork
From:       Mirko Stocker <me () misto ! ch>
Date:       2007-07-03 21:42:52
Message-ID: 200707032342.57163.me () misto ! ch
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On Monday 02 July 2007 22:02:22 Matthew Woehlke wrote:
> Nope, if anything this seems worse than your previous patch. Note: I
> rather strongly suspect this is not the highlighter's fault, but the
> renderer's fault. (You have 'show static word wrap indicator' turned on,
> right?)

Ok, so I tried to fix it in the renderer. That's the best way I found so far, 
but handles only the foreground color of not selected text, but I think I can 
implement the rest in a similar fashion.
What I don't understand is, what does this have to do with the 'show static 
word wrap indicator'? I can't see any difference whether it is on or off.

> This does seem fixed! :-) However, I don't understand why; something
> about constructing from pointers? Or did I miss something?

I suppose the problem arised because the defaultStyleList's own items were 
modified through the pointer.

> Btw, are you on IRC?

No usually not.. is there a kwrite-devel channel somewhere? But you can always 
contact me through jabber (misto@swissjabber.ch), ICQ (100422201)
 or MSN (mirkostocker@hotmail.com) if you like.

Regards

Mirko


["normal_color_renderer.patch" (text/x-diff)]

Index: render/katerenderer.cpp
===================================================================
--- render/katerenderer.cpp	(revision 682486)
+++ render/katerenderer.cpp	(working copy)
@@ -427,6 +427,11 @@
   }
 
   if (range->layout()) {
+	  
+	if(range->textLine()->attributesList().empty()) {
+	  paint.setPen(attribute(KateExtendedAttribute::dsNormal)->foreground().color());
+	}  
+	  
     QVector<QTextLayout::FormatRange> additionalFormats;
     if (range->length() > 0) {
       // Draw the text :)

["signature.asc" (application/pgp-signature)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]