[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: yup,   kate's HL code is bork
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2007-07-02 20:02:22
Message-ID: f6blkf$7ma$1 () sea ! gmane ! org
[Download RAW message or body]

Mirko Stocker wrote:
> On Wednesday 27 June 2007 00:29:34 Matthew Woehlke wrote:
>> Nope... that does seem to fix the non-highlighter, but the problem still
>> occurs with highlighters (try Scripts/Bash, for example). Therefore I'm
>> not convinced that this is the problem; sorry :-).
> 
> I think I've got it now :) The attached patch fixes the highlighting of the 
> normal text

Nope, if anything this seems worse than your previous patch. Note: I 
rather strongly suspect this is not the highlighter's fault, but the 
renderer's fault. (You have 'show static word wrap indicator' turned on, 
right?)

> and also solves the problem with the wrong highlightings being used.

This does seem fixed! :-) However, I don't understand why; something 
about constructing from pointers? Or did I miss something?

> PS: If I would apply for an SVN account, would it still be ok to send patches 
> to this list so someone can review them?

Absolutely! I still do that with any patches I don't consider "straight 
forward" or when I am less than convinced of a patch's correctness. Now, 
as for whether or not you'll get a reply, YMMV :-(. Probably I will try 
to review kate patches, although I'm about as expert as you with respect 
to much of kate (selection is about the only thing of which I might 
claim to have a decent understanding).

Btw, are you on IRC?

-- 
Matthew
/bin/sh -- still Bourne on Solaris (and still not POSIX compliant)

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]