[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Fw: Oracle10g SQL syntax highlighting 2
From:       "Yury Lebedev" <yurylebedev () mail ! ru>
Date:       2005-04-04 6:38:06
Message-ID: 003a01c538e1$558d7c60$6132a8c0 () lurestation
[Download RAW message or body]

Hi Dominik

I changed these rules so didn't know the exact meaning of the 'column' 
attribute. If it's supposed to mark rule to be at the beginning of line, my 
changes are unnecessary then (but I don't think the such improvements of a 
regexpr is the good idea - it is much powerful already :-) Feel free to 
cancel changes in these 3 lines (or commit them without 'column' attribute - 
it's for your choice).

Thanks,
Yury Lebedev

----- Original Message ----- 
From: "Dominik Haumann" <dhdev@gmx.de>
To: <kwrite-devel@kde.org>; "Yury Lebedev (Private Person)" 
<yurylebedev@mail.ru>
Sent: Saturday, April 02, 2005 12:28 AM
Subject: Re: Fw: Oracle10g SQL syntax highlighting 2

Hi,

a diff shows also:

-        <RegExpr attribute="Comment" context="SQL*Plus remark directive" 
String="rem\b" insensitive="true" column="0"/>
+        <RegExpr attribute="Comment" context="SQL*Plus remark directive" 
String="^rem\b" insensitive="true" column="0"/>

-        <RegExpr attribute="Symbol" context="#stay" String="/$" 
column="0"/>
-        <RegExpr attribute="Preprocessor" context="SQL*Plus directive to 
include file" String="@@?[^@ \t\r\n]" column="0"/>
+        <RegExpr attribute="Symbol" context="#stay" String="^/$" 
column="0"/>
+        <RegExpr attribute="Preprocessor" context="SQL*Plus directive to 
include file" String="^@@?[^@ \t\r\n]" column="0"/>

In this rules you added the leading ^ to mark the beginning of the line.
As the column="0" property is supposed to do this, it should not be 
necessary
to add it, or does it not work?

Besides that, the changes/patch seems to be fine. I will wait for your 
reply,
before I commit.

Thanks,
-- 
Dominik 

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]