[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Fw: Oracle10g SQL syntax highlighting 2
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2005-04-01 20:28:47
Message-ID: 200504012228.49703.dhdev () gmx ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi,

a diff shows also:

-        <RegExpr attribute="Comment" context="SQL*Plus remark directive" \
String="rem\b" insensitive="true" column="0"/> +        <RegExpr attribute="Comment" \
context="SQL*Plus remark directive" String="^rem\b" insensitive="true" column="0"/>

-        <RegExpr attribute="Symbol" context="#stay" String="/$" column="0"/>
-        <RegExpr attribute="Preprocessor" context="SQL*Plus directive to include \
file" String="@@?[^@ \t\r\n]" column="0"/> +        <RegExpr attribute="Symbol" \
context="#stay" String="^/$" column="0"/> +        <RegExpr attribute="Preprocessor" \
context="SQL*Plus directive to include file" String="^@@?[^@ \t\r\n]" column="0"/>

In this rules you added the leading ^ to mark the beginning of the line.
As the column="0" property is supposed to do this, it should not be necessary
to add it, or does it not work?

Besides that, the changes/patch seems to be fine. I will wait for your reply,
before I commit.

Thanks,
-- 
Dominik
GPG Fingerprint: AC88 49E3 D8A5 0541 5B71 AC6E 29AA 1696 FF64 EDBC
User-Agent: KMail; Desktop: KDE; OS: Gentoo/Linux; *free software*


[Attachment #5 (application/pgp-signature)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]