[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 103948: Remove "Display borders on maximized windows"
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-03-21 21:33:57
Message-ID: 20130321213357.17030.62130 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103948/
-----------------------------------------------------------
(Updated March 21, 2013, 9:33 p.m.)
Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.
Changes
-------
Add an old bug - it's imo sufficiently covered because moving onedimensionally \
maximized windows will behave like moving maximized ones (ie. more difficult, but not \
impossible)
Description
-------
Actually the only thing the patch does not is what's stated in the summary ;-)
- The setting is ignored, the decoration always gets a "true" for it
- moving a maximized window requires breaking a "strong" snap (1/16 of screen height \
- unless you use quick maximization)
- all snapping is done towards the client, not the frame
- QuickTileMode is exported to the decoration (just as the maximizeMode) so that it \
can fix the bordersize alongside that. (I've a sample implementation in local Bespin \
as inspiration for other decos)
Ratio:
It's simply not possible to perform the specialstate snapping in the core.
Either the decoration gets clipped, but that also clips titlebar buttons -> fail
Or the decoration gets resized "under the hood" (ie. we override border_* after \
obtaining it) but that has bad visual impact on decorations like plastik (where the \
client visually overflows the border, it clearly looks like the client is patched \
onto the deco) -> fail
-> the deco is informed about those special states and can drop some of its borders \
or not. Should be no major problem for oxygen (since it blends into clients anyway) \
but i've not checked how to make use of that in aurorae (or even its client code)
This addresses bugs 91703 and 299245.
http://bugs.kde.org/show_bug.cgi?id=91703
http://bugs.kde.org/show_bug.cgi?id=299245
Diffs
-----
kwin/workspace.h e033ac9
kwin/libkdecorations/kdecoration_p.cpp 5b54369
kwin/libkdecorations/kdecorationbridge.h 2cb36c9
kwin/libkwineffects/kwinglobals.h dba4324
kwin/kcmkwin/kwindecoration/preview.cpp 94aacba
kwin/libkdecorations/kdecoration.h 2c20767
kwin/libkdecorations/kdecoration.cpp 7ccbdb6
kwin/libkdecorations/kdecoration_p.h 71833cd
kwin/bridge.h 35efc90
kwin/bridge.cpp 31d285e
kwin/client.h 0c9d1d2
kwin/client.cpp f2338d4
kwin/geometry.cpp 372a4c8
kwin/kcmkwin/kwindecoration/preview.h 420e302
Diff: http://git.reviewboard.kde.org/r/103948/diff/
Testing
-------
With the (still local) changes to bespin I get nice partial clipping for quicktiled \
(or partially maximized) windows. Helped me to clean up some bespin deco code as well \
=)
Thanks,
Thomas Lübking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103948/">http://git.reviewboard.kde.org/r/103948/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 21, 2013, 9:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add an old bug - it's imo sufficiently covered because moving \
onedimensionally maximized windows will behave like moving maximized ones (ie. more \
difficult, but not impossible)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Actually the only thing the patch does not is what's stated in the \
summary ;-)
- The setting is ignored, the decoration always gets a "true" for it
- moving a maximized window requires breaking a "strong" snap (1/16 of \
screen height - unless you use quick maximization)
- all snapping is done towards the client, not the frame
- QuickTileMode is exported to the decoration (just as the maximizeMode) so that it \
can fix the bordersize alongside that. (I've a sample implementation in local \
Bespin as inspiration for other decos)
Ratio:
It's simply not possible to perform the specialstate snapping in the core.
Either the decoration gets clipped, but that also clips titlebar buttons -> fail
Or the decoration gets resized "under the hood" (ie. we override border_* \
after obtaining it) but that has bad visual impact on decorations like plastik (where \
the client visually overflows the border, it clearly looks like the client is patched \
onto the deco) -> fail
-> the deco is informed about those special states and can drop some of its \
borders or not. Should be no major problem for oxygen (since it blends into clients \
anyway) but i've not checked how to make use of that in aurorae (or even its \
client code)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With the (still local) changes to bespin I get nice partial clipping for \
quicktiled (or partially maximized) windows. Helped me to clean up some bespin deco \
code as well =)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=91703">91703</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=299245">299245</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/workspace.h <span style="color: grey">(e033ac9)</span></li>
<li>kwin/libkdecorations/kdecoration_p.cpp <span style="color: \
grey">(5b54369)</span></li>
<li>kwin/libkdecorations/kdecorationbridge.h <span style="color: \
grey">(2cb36c9)</span></li>
<li>kwin/libkwineffects/kwinglobals.h <span style="color: \
grey">(dba4324)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.cpp <span style="color: \
grey">(94aacba)</span></li>
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(2c20767)</span></li>
<li>kwin/libkdecorations/kdecoration.cpp <span style="color: \
grey">(7ccbdb6)</span></li>
<li>kwin/libkdecorations/kdecoration_p.h <span style="color: \
grey">(71833cd)</span></li>
<li>kwin/bridge.h <span style="color: grey">(35efc90)</span></li>
<li>kwin/bridge.cpp <span style="color: grey">(31d285e)</span></li>
<li>kwin/client.h <span style="color: grey">(0c9d1d2)</span></li>
<li>kwin/client.cpp <span style="color: grey">(f2338d4)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(372a4c8)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.h <span style="color: \
grey">(420e302)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103948/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic