[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 103948: Remove "Display borders on maximized windows"
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-03-22 10:27:41
Message-ID: 20130322102741.4864.47013 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103948/#review29683
-----------------------------------------------------------
Ship it!
given that I merged the unexport or bridge today, I'd say it should be merged
kwin/libkdecorations/kdecoration.cpp
<http://git.reviewboard.kde.org/r/103948/#comment22116>
please add a QT5 or KF5 to the TODO, so that we can grep for it
kwin/workspace.h
<http://git.reviewboard.kde.org/r/103948/#comment22117>
?
- Martin Gräßlin
On March 21, 2013, 10:33 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103948/
> -----------------------------------------------------------
>
> (Updated March 21, 2013, 10:33 p.m.)
>
>
> Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.
>
>
> Description
> -------
>
> Actually the only thing the patch does not is what's stated in the summary ;-)
>
> - The setting is ignored, the decoration always gets a "true" for it
> - moving a maximized window requires breaking a "strong" snap (1/16 of screen \
> height - unless you use quick maximization)
> - all snapping is done towards the client, not the frame
> - QuickTileMode is exported to the decoration (just as the maximizeMode) so that it \
> can fix the bordersize alongside that. (I've a sample implementation in local \
> Bespin as inspiration for other decos)
> Ratio:
> It's simply not possible to perform the specialstate snapping in the core.
> Either the decoration gets clipped, but that also clips titlebar buttons -> fail
> Or the decoration gets resized "under the hood" (ie. we override border_* after \
> obtaining it) but that has bad visual impact on decorations like plastik (where the \
> client visually overflows the border, it clearly looks like the client is patched \
> onto the deco) -> fail
> -> the deco is informed about those special states and can drop some of its borders \
> or not. Should be no major problem for oxygen (since it blends into clients anyway) \
> but i've not checked how to make use of that in aurorae (or even its client code)
>
> This addresses bugs 91703 and 299245.
> http://bugs.kde.org/show_bug.cgi?id=91703
> http://bugs.kde.org/show_bug.cgi?id=299245
>
>
> Diffs
> -----
>
> kwin/workspace.h e033ac9
> kwin/libkdecorations/kdecoration_p.cpp 5b54369
> kwin/libkdecorations/kdecorationbridge.h 2cb36c9
> kwin/libkwineffects/kwinglobals.h dba4324
> kwin/kcmkwin/kwindecoration/preview.cpp 94aacba
> kwin/libkdecorations/kdecoration.h 2c20767
> kwin/libkdecorations/kdecoration.cpp 7ccbdb6
> kwin/libkdecorations/kdecoration_p.h 71833cd
> kwin/bridge.h 35efc90
> kwin/bridge.cpp 31d285e
> kwin/client.h 0c9d1d2
> kwin/client.cpp f2338d4
> kwin/geometry.cpp 372a4c8
> kwin/kcmkwin/kwindecoration/preview.h 420e302
>
> Diff: http://git.reviewboard.kde.org/r/103948/diff/
>
>
> Testing
> -------
>
> With the (still local) changes to bespin I get nice partial clipping for quicktiled \
> (or partially maximized) windows. Helped me to clean up some bespin deco code as \
> well =)
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103948/">http://git.reviewboard.kde.org/r/103948/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">given that I merged the \
unexport or bridge today, I'd say it should be merged</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103948/diff/4/?file=115263#file115263line625" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/libkdecorations/kdecoration.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KDecorationOptions::BorderSize \
KDecorationOptions::preferredBorderSize(KDecorationFactory* factory) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">615</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">d</span><span class="o">-></span><span \
class="n">move_resize_maximized_windows</span><span class="p">;</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">625</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// </span><span class="cs">TODO</span><span class="c1"> remove function \
with API break</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please add \
a QT5 or KF5 to the TODO, so that we can grep for it</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103948/diff/4/?file=115268#file115268line1009" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/workspace.h</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">inline \
bool Workspace::decorationSupportsBlurBehind() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1009</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">?</pre> \
</div> <br />
<p>- Martin</p>
<br />
<p>On March 21st, 2013, 10:33 p.m. CET, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 21, 2013, 10:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Actually the only thing the patch does not is what's stated in the \
summary ;-)
- The setting is ignored, the decoration always gets a "true" for it
- moving a maximized window requires breaking a "strong" snap (1/16 of \
screen height - unless you use quick maximization)
- all snapping is done towards the client, not the frame
- QuickTileMode is exported to the decoration (just as the maximizeMode) so that it \
can fix the bordersize alongside that. (I've a sample implementation in local \
Bespin as inspiration for other decos)
Ratio:
It's simply not possible to perform the specialstate snapping in the core.
Either the decoration gets clipped, but that also clips titlebar buttons -> fail
Or the decoration gets resized "under the hood" (ie. we override border_* \
after obtaining it) but that has bad visual impact on decorations like plastik (where \
the client visually overflows the border, it clearly looks like the client is patched \
onto the deco) -> fail
-> the deco is informed about those special states and can drop some of its \
borders or not. Should be no major problem for oxygen (since it blends into clients \
anyway) but i've not checked how to make use of that in aurorae (or even its \
client code)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With the (still local) changes to bespin I get nice partial clipping for \
quicktiled (or partially maximized) windows. Helped me to clean up some bespin deco \
code as well =)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=91703">91703</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=299245">299245</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/workspace.h <span style="color: grey">(e033ac9)</span></li>
<li>kwin/libkdecorations/kdecoration_p.cpp <span style="color: \
grey">(5b54369)</span></li>
<li>kwin/libkdecorations/kdecorationbridge.h <span style="color: \
grey">(2cb36c9)</span></li>
<li>kwin/libkwineffects/kwinglobals.h <span style="color: \
grey">(dba4324)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.cpp <span style="color: \
grey">(94aacba)</span></li>
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(2c20767)</span></li>
<li>kwin/libkdecorations/kdecoration.cpp <span style="color: \
grey">(7ccbdb6)</span></li>
<li>kwin/libkdecorations/kdecoration_p.h <span style="color: \
grey">(71833cd)</span></li>
<li>kwin/bridge.h <span style="color: grey">(35efc90)</span></li>
<li>kwin/bridge.cpp <span style="color: grey">(31d285e)</span></li>
<li>kwin/client.h <span style="color: grey">(0c9d1d2)</span></li>
<li>kwin/client.cpp <span style="color: grey">(f2338d4)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(372a4c8)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.h <span style="color: \
grey">(420e302)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103948/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic