'Re: Review Request 109639: Use a Loader for the Virtual Desktop OSD'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 109639: Use a Loader for the Virtual Desktop OSD
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2013-03-22 7:11:52
Message-ID: 20130322071152.20287.97552 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On March 21, 2013, 8:18 p.m., Thomas Lübking wrote:
> > Does it also workaround the KWindowSystem::comspositingChanged() issue?

No :-( that was in fact the complete idea behind it.

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109639/#review29654
-----------------------------------------------------------

On March 21, 2013, 12:21 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109639/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 12:21 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Use a Loader for the Virtual Desktop OSD
> 
> The complete dialog is moved into a Loader item and it gets loaded on
> first change of virtual desktop. This change should result in less
> parsing on startup and moving the cost of the loading to the time when
> its really needed.
> 
> 
> Diffs
> -----
> 
>   kwin/scripts/desktopchangeosd/contents/ui/main.qml c93896ccbf92a70965954ddea05ec99c984058e9 
>   kwin/scripts/desktopchangeosd/contents/ui/osd.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109639/diff/
> 
> 
> Testing
> -------
> 
> tested all settings somehow influencing the OSD.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109639/">http://git.reviewboard.kde.org/r/109639/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 21st, 2013, 8:18 p.m. CET, <b>Thomas \
Lübking</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Does it also workaround the KWindowSystem::comspositingChanged() \
issue?</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No :-( that was in fact \
the complete idea behind it.</pre> <br />

<p>- Martin</p>

<br />
<p>On March 21st, 2013, 12:21 p.m. CET, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated March 21, 2013, 12:21 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use a Loader for the Virtual Desktop OSD

The complete dialog is moved into a Loader item and it gets loaded on
first change of virtual desktop. This change should result in less
parsing on startup and moving the cost of the loading to the time when
its really needed.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested all settings somehow influencing the OSD.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scripts/desktopchangeosd/contents/ui/main.qml <span style="color: \
grey">(c93896ccbf92a70965954ddea05ec99c984058e9)</span></li>

 <li>kwin/scripts/desktopchangeosd/contents/ui/osd.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109639/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 