[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Use the invalid NULL uuid instead of "ALL" to indeicate the "on all activities"
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2013-01-02 18:20:17
Message-ID: 20130102182017.3951.46982 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 2, 2013, 8:38 a.m., Martin Gräßlin wrote:
> > kwin/client.cpp, line 1505
> > <http://git.reviewboard.kde.org/r/107855/diff/3/?file=103543#file103543line1505>
> >
> > @Ivan: could that define become part of the public API?
>
> Ivan Čukić wrote:
> I really don't think that kactivities should provide api for uuid when there \
> already is QUuid.
> Adding it to apidox would be bearable.
>
> Thomas Lübking wrote:
> "Because you're not yourself"
>
> The string is hardcoded in libkactivities, QUuid().toString() is actually \
> "{00000000-0000-0000-0000-000000000000}" and \
> QUuid("00000000-0000-0000-0000-000000000000").isNull() is true by implementation \
> detail only (half sentence in QUuid API doc that you can omit the curlies)
> I assume the string is hardcoded in kactivties because you didn't want the braces?
> -> What uuid should we set on the window?
> -> How will other clients react to that?
>
> I don't want to get back to "why a string representation instead of the 16 RFC4122 \
> bytes", but the current implemention deviates from QUuid (or rather QUuid deviates \
> from RFC4122 which does not describe curly braces) and needs to be specified or \
> based upon a common source (QUuid)
>
>
I intend to stash it until RC3 is open
(so we can sort out the hash invocation and provide update scripts, fix rules kcm(?) \
and align kactivities)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107855/#review24409
-----------------------------------------------------------
On Dec. 31, 2012, 8:24 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107855/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2012, 8:24 p.m.)
>
>
> Review request for kwin, Ivan Čukić and Martin Gräßlin.
>
>
> Description
> -------
>
> When the activity daemon is not reposponding, the lib cache will answer with the \
> null activity which is so far just "invalid", cannot be activate and by this its \
> not a good idea to assign any window to it (happens when you open a window and it \
> gets on the current "null" activity)
> Using it instead of the "ALL" property is more robust (anytime there's sth. \
> slightly wrong in the system we fall back to "on all activities" rather than \
> loosing windows on some unreachable activities) as well as more consistent (there's \
> now always a uuid string as activity property)
> Notice that there's a pending reference to "ALL" in \
> "service/ui/plugins/declarativeui/DeclarativeUi.cpp" which Ivan wants to scratch as \
> soon as we use the null uuid in git master.
>
> Diffs
> -----
>
> kwin/client.cpp b555c11
>
> Diff: http://git.reviewboard.kde.org/r/107855/diff/
>
>
> Testing
> -------
>
> No regression spotted.
> Reg. the original problem:
> semi - i once ran into one or more window/s being on that id, not with the patch \
> since after.
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107855/">http://git.reviewboard.kde.org/r/107855/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 2nd, 2013, 8:38 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107855/diff/3/?file=103543#file103543line1505" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/client.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Client::setOnActivity(const QString &activity, bool enable)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1505</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#define NULL_UUID \
"00000000-0000-0000-0000-000000000000"</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Ivan: could that define \
become part of the public API?</pre> </blockquote>
<p>On January 2nd, 2013, 11:40 a.m., <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I really don't think \
that kactivities should provide api for uuid when there already is QUuid.
Adding it to apidox would be bearable.</pre>
</blockquote>
<p>On January 2nd, 2013, 3:21 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Because you're \
not yourself"
The string is hardcoded in libkactivities, QUuid().toString() is actually \
"{00000000-0000-0000-0000-000000000000}" and \
QUuid("00000000-0000-0000-0000-000000000000").isNull() is true by \
implementation detail only (half sentence in QUuid API doc that you can omit the \
curlies)
I assume the string is hardcoded in kactivties because you didn't want the \
braces?
-> What uuid should we set on the window?
-> How will other clients react to that?
I don't want to get back to "why a string representation instead of the 16 \
RFC4122 bytes", but the current implemention deviates from QUuid (or rather \
QUuid deviates from RFC4122 which does not describe curly braces) and needs to be \
specified or based upon a common source (QUuid)
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I intend to \
stash it until RC3 is open (so we can sort out the hash invocation and provide update \
scripts, fix rules kcm(?) and align kactivities)</pre> <br />
<p>- Thomas</p>
<br />
<p>On December 31st, 2012, 8:24 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Ivan Čukić and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 8:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the activity daemon is not reposponding, the lib cache will answer \
with the null activity which is so far just "invalid", cannot be activate \
and by this its not a good idea to assign any window to it (happens when you open a \
window and it gets on the current "null" activity)
Using it instead of the "ALL" property is more robust (anytime there's \
sth. slightly wrong in the system we fall back to "on all activities" \
rather than loosing windows on some unreachable activities) as well as more \
consistent (there's now always a uuid string as activity property)
Notice that there's a pending reference to "ALL" in \
"service/ui/plugins/declarativeui/DeclarativeUi.cpp" which Ivan wants to \
scratch as soon as we use the null uuid in git master.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No regression spotted. Reg. the original problem:
semi - i once ran into one or more window/s being on that id, not with the patch \
since after.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(b555c11)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107855/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic