From kwin Wed Jan 02 18:20:17 2013 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Wed, 02 Jan 2013 18:20:17 +0000 To: kwin Subject: Re: Review Request: Use the invalid NULL uuid instead of "ALL" to indeicate the "on all activities" Message-Id: <20130102182017.3951.46982 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=135715083330972 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0706751263821894920==" --===============0706751263821894920== Content-Type: multipart/alternative; boundary="===============3300486713861340546==" --===============3300486713861340546== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Jan. 2, 2013, 8:38 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > > kwin/client.cpp, line 1505 > > > > > > @Ivan: could that define become part of the public API? > = > Ivan =C4=8Cuki=C4=87 wrote: > I really don't think that kactivities should provide api for uuid whe= n there already is QUuid. > = > Adding it to apidox would be bearable. > = > Thomas L=C3=BCbking wrote: > "Because you're not yourself" > = > The string is hardcoded in libkactivities, QUuid().toString() is actu= ally "{00000000-0000-0000-0000-000000000000}" and QUuid("00000000-0000-0000= -0000-000000000000").isNull() is true by implementation detail only (half s= entence in QUuid API doc that you can omit the curlies) > = > I assume the string is hardcoded in kactivties because you didn't wan= t the braces? > -> What uuid should we set on the window? > -> How will other clients react to that? > = > I don't want to get back to "why a string representation instead of t= he 16 RFC4122 bytes", but the current implemention deviates from QUuid (or= rather QUuid deviates from RFC4122 which does not describe curly braces) a= nd needs to be specified or based upon a common source (QUuid) > = > = > I intend to stash it until RC3 is open (so we can sort out the hash invocation and provide update scripts, fix rul= es kcm(?) and align kactivities) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107855/#review24409 ----------------------------------------------------------- On Dec. 31, 2012, 8:24 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107855/ > ----------------------------------------------------------- > = > (Updated Dec. 31, 2012, 8:24 p.m.) > = > = > Review request for kwin, Ivan =C4=8Cuki=C4=87 and Martin Gr=C3=A4=C3=9Fli= n. > = > = > Description > ------- > = > When the activity daemon is not reposponding, the lib cache will answer w= ith the null activity which is so far just "invalid", cannot be activate an= d by this its not a good idea to assign any window to it (happens when you = open a window and it gets on the current "null" activity) > = > Using it instead of the "ALL" property is more robust (anytime there's st= h. slightly wrong in the system we fall back to "on all activities" rather = than loosing windows on some unreachable activities) as well as more consis= tent (there's now always a uuid string as activity property) > = > Notice that there's a pending reference to "ALL" in "service/ui/plugins/d= eclarativeui/DeclarativeUi.cpp" which Ivan wants to scratch as soon as we u= se the null uuid in git master. > = > = > Diffs > ----- > = > kwin/client.cpp b555c11 = > = > Diff: http://git.reviewboard.kde.org/r/107855/diff/ > = > = > Testing > ------- > = > No regression spotted. > Reg. the original problem: > semi - i once ran into one or more window/s being on that id, not with th= e patch since after. > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============3300486713861340546== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107855/

On January 2nd, 2013, 8:38 a.m., Martin Gr= =C3=A4=C3=9Flin wrote:

= = =
kwin/client.cpp (Diff revision 3) 
void Client::setOnActivity(const QString &activity, bool enable=
)
 

    1505
    
#define NULL_UUID "000=
00000-0000-0000-0000-000000000000"

  


 




  
@Ivan: co=
uld that define become part of the public API?

 




 
On January 2nd, 2013, 11:40 a.m., Ivan =C4=8Cuki=C4=87 wrote:

 

  
I really =
don't think that kactivities should provide api for uuid when there alr=
eady is QUuid.

Adding it to apidox would be bearable.

 






 
On January 2nd, 2013, 3:21 p.m., Thomas L=C3=BCbking wrote:

 

  
"Bec=
ause you're not yourself"

The string is hardcoded in libkactivities, QUuid().toString() is actually &=
quot;{00000000-0000-0000-0000-000000000000}" and QUuid("00000000-=
0000-0000-0000-000000000000").isNull() is true by implementation detai=
l only (half sentence in QUuid API doc that you can omit the curlies)

I assume the string is hardcoded in kactivties because you didn't want =
the braces?
-> What uuid should we set on the window?
-> How will other clients react to that?

I don't want to get back to "why a string representation instead o=
f the 16 RFC4122 bytes", but the current implemention deviates  from Q=
Uuid (or rather QUuid deviates from RFC4122 which does not describe curly b=
races) and needs to be specified or based upon a common source (QUuid)




 











I intend to stash it until RC3 is open
(so we can sort out the hash invocation and provide update scripts, fix rul=
es kcm(?) and align kactivities)








- Thomas






On December 31st, 2012, 8:24 p.m., Thomas L=C3=BCbking wrote:









 

  


Review request for kwin, Ivan =C4=8Cuki=C4=87 and Martin Gr=C3=A4=C3=
=9Flin.


By Thomas L=C3=BCbking.




Updated Dec. 31, 2012, 8:24 p.m.








Descripti=
on 

 

 

  
   
When the activity daemon is not reposponding, the lib cache =
will answer with the null activity which is so far just "invalid"=
, cannot be activate and by this its not a good idea to assign any window t=
o it (happens when you open a window and it gets on the current "null&=
quot; activity)

Using it instead of the "ALL" property is more robust (anytime th=
ere's sth. slightly wrong in the system we fall back to "on all ac=
tivities" rather than loosing windows on some unreachable activities) =
as well as more consistent (there's now always a uuid string as activit=
y property)

Notice that there's a pending reference to "ALL" in "ser=
vice/ui/plugins/declarativeui/DeclarativeUi.cpp" which Ivan wants to s=
cratch as soon as we use the null uuid in git master.

  		
 






Testing <=
/h1>


 

  
   
No regression spotted.
Reg. the original problem:
semi - i once ran into one or more window/s being on that id, not with the =
patch since after.

  		
 








Diffs=
 


    

 
  • kwin/client.cpp (b555c11)
    • 





View Diff





  		
 











  

 



--===============3300486713861340546==--

--===============0706751263821894920==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

--===============0706751263821894920==--