This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107855/ |
On January 2nd, 2013, 8:38 a.m., Martin Gräßlin wrote:
kwin/client.cpp (Diff revision 3) void Client::setOnActivity(const QString &activity, bool enable)1505 #define NULL_UUID "00000000-0000-0000-0000-000000000000"
@Ivan: could that define become part of the public API?On January 2nd, 2013, 11:40 a.m., Ivan Čukić wrote:
I really don't think that kactivities should provide api for uuid when there already is QUuid. Adding it to apidox would be bearable.On January 2nd, 2013, 3:21 p.m., Thomas Lübking wrote:
"Because you're not yourself" The string is hardcoded in libkactivities, QUuid().toString() is actually "{00000000-0000-0000-0000-000000000000}" and QUuid("00000000-0000-0000-0000-000000000000").isNull() is true by implementation detail only (half sentence in QUuid API doc that you can omit the curlies) I assume the string is hardcoded in kactivties because you didn't want the braces? -> What uuid should we set on the window? -> How will other clients react to that? I don't want to get back to "why a string representation instead of the 16 RFC4122 bytes", but the current implemention deviates from QUuid (or rather QUuid deviates from RFC4122 which does not describe curly braces) and needs to be specified or based upon a common source (QUuid)
I intend to stash it until RC3 is open (so we can sort out the hash invocation and provide update scripts, fix rules kcm(?) and align kactivities)
- Thomas
On December 31st, 2012, 8:24 p.m., Thomas Lübking wrote:
Review request for kwin, Ivan Čukić and Martin Gräßlin.
By Thomas Lübking.
Updated Dec. 31, 2012, 8:24 p.m. Description
Testing
Diffs
|