[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: improve present windows with DnD actions
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-30 15:58:42
Message-ID: 20121230155842.14927.97463 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 24, 2012, 5:07 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > Have not tried it yet - I guess the patch depends on the other review, =
so it's too late for 4.9 anyway.
> > =
> > Somehow I fail to imagine how to use DnD with present windows. I assum=
e you have to use the keyboard to actually select the window you want to dr=
ag to, right? Mouse interaction (click to select) is probably broken?
> =
> Thomas L=C3=BCbking wrote:
> w/o the other patch DnD into present windows will nearby inevitably c=
rash the client, so yes.
> interaction w/o kbd is not (yet) possible because the moment you atte=
mpt to click, you loose the drag.
> =
> the only way around this would be to hover and wait (and then automat=
ically select the window after a second or so) - since we can check whether=
there's a dnd (sends client messages the input window can receive regardle=
ss of whether dnd grabs the pointer) this actually could be an option for t=
his case.
> =
> Thomas L=C3=BCbking wrote:
> =C3=84hhhh "Bump" - should we get this into 4.10?
bump for "yes or no".
i could easily introduce a hover timeout (ie. on DnD, move the cursor onto =
a window, hold it "still" for ~600ms to auto-activate the window)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105341/#review15069
-----------------------------------------------------------
On June 24, 2012, 2:02 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105341/
> -----------------------------------------------------------
> =
> (Updated June 24, 2012, 2:02 p.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> present windows needed a little for this love after all ...
> =
> =
> Diffs
> -----
> =
> kwin/effects/presentwindows/presentwindows.h 7105266 =
> kwin/effects/presentwindows/presentwindows.cpp 4ffa3b0 =
> =
> Diff: http://git.reviewboard.kde.org/r/105341/diff/
> =
> =
> Testing
> -------
> =
> yupp - you don't figure this w/o ;-)
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105341/">http://git.reviewboard.kde.org/r/105341/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 24th, 2012, 5:07 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Have not tried it yet - I guess the patch depends on the other review, \
so it's too late for 4.9 anyway.
Somehow I fail to imagine how to use DnD with present windows. I assume you have to \
use the keyboard to actually select the window you want to drag to, right? Mouse \
interaction (click to select) is probably broken?</pre> </blockquote>
<p>On June 24th, 2012, 5:34 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">w/o the other patch DnD \
into present windows will nearby inevitably crash the client, so yes. interaction w/o \
kbd is not (yet) possible because the moment you attempt to click, you loose the \
drag.
the only way around this would be to hover and wait (and then automatically select \
the window after a second or so) - since we can check whether there's a dnd \
(sends client messages the input window can receive regardless of whether dnd grabs \
the pointer) this actually could be an option for this case.</pre> </blockquote>
<p>On October 25th, 2012, 6:32 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ähhhh "Bump" \
- should we get this into 4.10?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">bump for "yes or \
no". i could easily introduce a hover timeout (ie. on DnD, move the cursor onto \
a window, hold it "still" for ~600ms to auto-activate the window) </pre>
<br />
<p>- Thomas</p>
<br />
<p>On June 24th, 2012, 2:02 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated June 24, 2012, 2:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">present windows needed a little for this love after all ...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yupp - you don't figure this w/o ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/presentwindows/presentwindows.h <span style="color: \
grey">(7105266)</span></li>
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(4ffa3b0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105341/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic