This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105341/

On June 24th, 2012, 5:07 p.m., Martin Gräßlin wrote:

Have not tried it yet - I guess the patch depends on the other review, so it's too late for 4.9 anyway.

Somehow I fail to imagine how to use DnD with present windows.  I assume you have to use the keyboard to actually select the window you want to drag to, right? Mouse interaction (click to select) is probably broken?

On June 24th, 2012, 5:34 p.m., Thomas Lübking wrote:

w/o the other patch DnD into present windows will nearby inevitably crash the client, so yes.
interaction w/o kbd is not (yet) possible because the moment you attempt to click, you loose the drag.

the only way around this would be to hover and wait (and then automatically select the window after a second or so) - since we can check whether there's a dnd (sends client messages the input window can receive regardless of whether dnd grabs the pointer) this actually could be an option for this case.

On October 25th, 2012, 6:32 p.m., Thomas Lübking wrote:

Ähhhh "Bump" - should we get this into 4.10?
bump for "yes or no".
i could easily introduce a hover timeout (ie. on DnD, move the cursor onto a window, hold it "still" for ~600ms to auto-activate the window)

- Thomas


On June 24th, 2012, 2:02 p.m., Thomas Lübking wrote:

Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Updated June 24, 2012, 2:02 p.m.

Description

present windows needed a little for this love after all ...

Testing

yupp - you don't figure this w/o ;-)

Diffs

  • kwin/effects/presentwindows/presentwindows.h (7105266)
  • kwin/effects/presentwindows/presentwindows.cpp (4ffa3b0)

View Diff