From kwin Sun Dec 30 15:58:42 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Sun, 30 Dec 2012 15:58:42 +0000 To: kwin Subject: Re: Review Request: improve present windows with DnD actions Message-Id: <20121230155842.14927.97463 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=135688313030426 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8155006290955290601==" --===============8155006290955290601== Content-Type: multipart/alternative; boundary="===============5012523124190223587==" --===============5012523124190223587== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 24, 2012, 5:07 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > Have not tried it yet - I guess the patch depends on the other review, = so it's too late for 4.9 anyway. > > = > > Somehow I fail to imagine how to use DnD with present windows. I assum= e you have to use the keyboard to actually select the window you want to dr= ag to, right? Mouse interaction (click to select) is probably broken? > = > Thomas L=C3=BCbking wrote: > w/o the other patch DnD into present windows will nearby inevitably c= rash the client, so yes. > interaction w/o kbd is not (yet) possible because the moment you atte= mpt to click, you loose the drag. > = > the only way around this would be to hover and wait (and then automat= ically select the window after a second or so) - since we can check whether= there's a dnd (sends client messages the input window can receive regardle= ss of whether dnd grabs the pointer) this actually could be an option for t= his case. > = > Thomas L=C3=BCbking wrote: > =C3=84hhhh "Bump" - should we get this into 4.10? bump for "yes or no". i could easily introduce a hover timeout (ie. on DnD, move the cursor onto = a window, hold it "still" for ~600ms to auto-activate the window) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105341/#review15069 ----------------------------------------------------------- On June 24, 2012, 2:02 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105341/ > ----------------------------------------------------------- > = > (Updated June 24, 2012, 2:02 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > present windows needed a little for this love after all ... > = > = > Diffs > ----- > = > kwin/effects/presentwindows/presentwindows.h 7105266 = > kwin/effects/presentwindows/presentwindows.cpp 4ffa3b0 = > = > Diff: http://git.reviewboard.kde.org/r/105341/diff/ > = > = > Testing > ------- > = > yupp - you don't figure this w/o ;-) > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============5012523124190223587== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105341/

On June 24th, 2012, 5:07 p.m., Martin Gr=C3= =A4=C3=9Flin wrote:

Have not =
tried it yet - I guess the patch depends on the other review, so it's t=
oo late for 4.9 anyway.

Somehow I fail to imagine how to use DnD with present windows.  I assume yo=
u have to use the keyboard to actually select the window you want to drag t=
o, right? Mouse interaction (click to select) is probably broken?

On June 24th, 2012, 5:34 p.m., Thomas L=C3=BCbking wrote:

w/o the o=
ther patch DnD into present windows will nearby inevitably crash the client=
, so yes.
interaction w/o kbd is not (yet) possible because the moment you attempt to=
 click, you loose the drag.

the only way around this would be to hover and wait (and then automatically=
 select the window after a second or so) - since we can check whether there=
's a dnd (sends client messages the input window can receive regardless=
 of whether dnd grabs the pointer) this actually could be an option for thi=
s case.

On October 25th, 2012, 6:32 p.m., Thomas L=C3=BCbking wrote:

=C3=84hhh=
h "Bump" - should we get this into 4.10?
bump for &q=
uot;yes or no".
i could easily introduce a hover timeout (ie. on DnD, move the cursor onto =
a window, hold it "still" for ~600ms to auto-activate the window)

- Thomas


On June 24th, 2012, 2:02 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated June 24, 2012, 2:02 p.m.

Descripti= on 

present windows needed a little for this love after all ...<=
/pre>

Testing <= /h1> 
yupp - you don't figure this w/o ;-)

Diffs=

  • kwin/effects/presentwindows/presentwindows.h (7105266)
  • kwin/effects/presentwindows/presentwindows.cpp (4ffa3b0)

View Diff
--===============5012523124190223587==-- --===============8155006290955290601== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============8155006290955290601==--