[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Check max viewport and texture dimensions for glViewport
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-30 13:27:39
Message-ID: 20121230132739.17877.2461 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 8, 2012, 7:24 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > can we somewhere tell the people where to change to XRender and how to =
suspend compositing?
> =
> Thomas L=C3=BCbking wrote:
> What about auto-launching "kcmshell4 kwincompositing" and refer to th=
e dialog?
> =
> Martin Gr=C3=A4=C3=9Flin wrote:
> would be a solution. Could we embedd a link to open the KCM? I think =
that should be possible, shouldn't it.
> =
> One more concern is the tech speak. Maybe replace the GL_MAX_FOO by a=
description? I fear that the translators will not be able to do anything w=
ith it.
> =
> Thomas L=C3=BCbking wrote:
> > Could we embedd a link to open the KCM?
> Afaics: No. (not simply)
> kdialog does not support active links (and i found no documented swit=
ch to alter that) and we cannot use a managed window.
> So we'd have to introduce our own dialog executable or get a patch in=
to kdialog (while i *guess* the lacking support is no accident, you could d=
o a lot of scripted s*** with that)
> =
> Another option would be to either call "sh -c" or pipe the command t=
hrough krun (what will effectively do the same), use a --yesno or --warning=
yesno dialog and " && kcmshell4 kwincompositing", but KProcess cannot perfo=
rm that logic operation (and we don want to runt that as a child process, d=
o we ;-)
> =
> Martin Gr=C3=A4=C3=9Flin wrote:
> another krazy idea: open kcmchell4 kwincompositing with an additional=
flag which is interpreted by the KCM to show the appropriate message inlin=
e:
> =
> "Your viewport is foo bar, you can change in advanced tab to xrender =
or disable"
> =
> Thomas L=C3=BCbking wrote:
> Cool idea.
> Pitfalls:
> - "don't ask again" case of the texture size limitation
> - if the settings are already up, you won't (easily) get it to interp=
ret any arguments (the kcmodule isn't rebuilt)
> =
> Martin Gr=C3=A4=C3=9Flin wrote:
> - the "don't ask again" part should be simple if we just store a conf=
ig value
> - DBus signals
ping.
do we want this (untranslated, ugly but better then nothing?) in 4.10?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106917/#review21644
-----------------------------------------------------------
On Nov. 10, 2012, 5:25 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106917/
> -----------------------------------------------------------
> =
> (Updated Nov. 10, 2012, 5:25 p.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> The patch checks
> 1. whether the requested dimension is beyond the propagated viewport capa=
bilities (and in case toggles compositing with a sorry)
> 2. Because recently MESA is a bit enthusiastic about the capabilities, al=
so whether the requested dimension is beyond the propagated texture capabil=
ities (and in case informs the user that this could or will lead to trouble=
, think of "maximized" windows)
> =
> =
> Diffs
> -----
> =
> kwin/kcmkwin/kwincompositing/dbus.h PRE-CREATION =
> kwin/kcmkwin/kwincompositing/main.h 35079c3 =
> kwin/kcmkwin/kwincompositing/main.cpp 84a2895 =
> kwin/scene_opengl.h 57d99ec =
> kwin/scene_opengl.cpp 4792c11 =
> =
> Diff: http://git.reviewboard.kde.org/r/106917/diff/
> =
> =
> Testing
> -------
> =
> Constrained the limits to "5" and either dropped out of compositing with =
the dialog or got the information dialog. "Do not show again" works as well=
. Dialog code is largely stolen from useractions.cpp.
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106917/">http://git.reviewboard.kde.org/r/106917/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 8th, 2012, 7:24 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">can we somewhere tell the people where to change to XRender and how to \
suspend compositing?</pre> </blockquote>
<p>On November 8th, 2012, 7:56 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about \
auto-launching "kcmshell4 kwincompositing" and refer to the dialog?</pre> \
</blockquote>
<p>On November 9th, 2012, 5:44 a.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">would be a solution. \
Could we embedd a link to open the KCM? I think that should be possible, \
shouldn't it.
One more concern is the tech speak. Maybe replace the GL_MAX_FOO by a description? I \
fear that the translators will not be able to do anything with it.</pre> \
</blockquote>
<p>On November 9th, 2012, 3:48 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Could we embedd a \
link to open the KCM?
Afaics: No. (not simply)
kdialog does not support active links (and i found no documented switch to alter \
that) and we cannot use a managed window. So we'd have to introduce our own \
dialog executable or get a patch into kdialog (while i *guess* the lacking support is \
no accident, you could do a lot of scripted s*** with that)
Another option would be to either call "sh -c" or pipe the command through \
krun (what will effectively do the same), use a --yesno or --warningyesno dialog and \
" && kcmshell4 kwincompositing", but KProcess cannot perform that \
logic operation (and we don want to runt that as a child process, do we ;-)</pre> \
</blockquote>
<p>On November 9th, 2012, 4:53 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">another krazy idea: open \
kcmchell4 kwincompositing with an additional flag which is interpreted by the KCM to \
show the appropriate message inline:
"Your viewport is foo bar, you can change in advanced tab to xrender or \
disable"</pre> </blockquote>
<p>On November 10th, 2012, 1:18 a.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cool idea. Pitfalls:
- "don't ask again" case of the texture size limitation
- if the settings are already up, you won't (easily) get it to interpret any \
arguments (the kcmodule isn't rebuilt)</pre> </blockquote>
<p>On November 10th, 2012, 8:07 a.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- the "don't \
ask again" part should be simple if we just store a config value
- DBus signals</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ping.
do we want this (untranslated, ugly but better then nothing?) in 4.10?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On November 10th, 2012, 5:25 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2012, 5:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch checks 1. whether the requested dimension is beyond the \
propagated viewport capabilities (and in case toggles compositing with a sorry) 2. \
Because recently MESA is a bit enthusiastic about the capabilities, also whether the \
requested dimension is beyond the propagated texture capabilities (and in case \
informs the user that this could or will lead to trouble, think of \
"maximized" windows)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Constrained the limits to "5" and either dropped out of \
compositing with the dialog or got the information dialog. "Do not show \
again" works as well. Dialog code is largely stolen from useractions.cpp.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwincompositing/dbus.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.h <span style="color: \
grey">(35079c3)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(84a2895)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(57d99ec)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(4792c11)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106917/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic