--===============6390101056352438989== Content-Type: multipart/alternative; boundary="===============8439747503189683986==" --===============8439747503189683986== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 8, 2012, 7:24 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > can we somewhere tell the people where to change to XRender and how to = suspend compositing? > = > Thomas L=C3=BCbking wrote: > What about auto-launching "kcmshell4 kwincompositing" and refer to th= e dialog? > = > Martin Gr=C3=A4=C3=9Flin wrote: > would be a solution. Could we embedd a link to open the KCM? I think = that should be possible, shouldn't it. > = > One more concern is the tech speak. Maybe replace the GL_MAX_FOO by a= description? I fear that the translators will not be able to do anything w= ith it. > = > Thomas L=C3=BCbking wrote: > > Could we embedd a link to open the KCM? > Afaics: No. (not simply) > kdialog does not support active links (and i found no documented swit= ch to alter that) and we cannot use a managed window. > So we'd have to introduce our own dialog executable or get a patch in= to kdialog (while i *guess* the lacking support is no accident, you could d= o a lot of scripted s*** with that) > = > Another option would be to either call "sh -c" or pipe the command t= hrough krun (what will effectively do the same), use a --yesno or --warning= yesno dialog and " && kcmshell4 kwincompositing", but KProcess cannot perfo= rm that logic operation (and we don want to runt that as a child process, d= o we ;-) > = > Martin Gr=C3=A4=C3=9Flin wrote: > another krazy idea: open kcmchell4 kwincompositing with an additional= flag which is interpreted by the KCM to show the appropriate message inlin= e: > = > "Your viewport is foo bar, you can change in advanced tab to xrender = or disable" > = > Thomas L=C3=BCbking wrote: > Cool idea. > Pitfalls: > - "don't ask again" case of the texture size limitation > - if the settings are already up, you won't (easily) get it to interp= ret any arguments (the kcmodule isn't rebuilt) > = > Martin Gr=C3=A4=C3=9Flin wrote: > - the "don't ask again" part should be simple if we just store a conf= ig value > - DBus signals ping. do we want this (untranslated, ugly but better then nothing?) in 4.10? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106917/#review21644 ----------------------------------------------------------- On Nov. 10, 2012, 5:25 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106917/ > ----------------------------------------------------------- > = > (Updated Nov. 10, 2012, 5:25 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > The patch checks > 1. whether the requested dimension is beyond the propagated viewport capa= bilities (and in case toggles compositing with a sorry) > 2. Because recently MESA is a bit enthusiastic about the capabilities, al= so whether the requested dimension is beyond the propagated texture capabil= ities (and in case informs the user that this could or will lead to trouble= , think of "maximized" windows) > = > = > Diffs > ----- > = > kwin/kcmkwin/kwincompositing/dbus.h PRE-CREATION = > kwin/kcmkwin/kwincompositing/main.h 35079c3 = > kwin/kcmkwin/kwincompositing/main.cpp 84a2895 = > kwin/scene_opengl.h 57d99ec = > kwin/scene_opengl.cpp 4792c11 = > = > Diff: http://git.reviewboard.kde.org/r/106917/diff/ > = > = > Testing > ------- > = > Constrained the limits to "5" and either dropped out of compositing with = the dialog or got the information dialog. "Do not show again" works as well= . Dialog code is largely stolen from useractions.cpp. > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============8439747503189683986== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106917/

On November 8th, 2012, 7:24 p.m., Martin Gr= =C3=A4=C3=9Flin wrote:

can we so=
mewhere tell the people where to change to XRender and how to suspend compo=
siting?

On November 8th, 2012, 7:56 p.m., Thomas L=C3=BCbking wrote:

What abou=
t auto-launching "kcmshell4 kwincompositing" and refer to the dia=
log?

On November 9th, 2012, 5:44 a.m., Martin Gr=C3=A4=C3=9Flin wrote= :

would be =
a solution. Could we embedd a link to open the KCM? I think that should be =
possible, shouldn't it.

One more concern is the tech speak. Maybe replace the GL_MAX_FOO by a descr=
iption? I fear that the translators will not be able to do anything with it=
.

On November 9th, 2012, 3:48 p.m., Thomas L=C3=BCbking wrote:

> Coul=
d we embedd a link to open the KCM?
Afaics: No. (not simply)
kdialog does not support active links (and i found no documented switch to =
alter that) and we cannot use a managed window.
So we'd have to introduce our own dialog executable or get a patch into=
 kdialog (while i *guess* the lacking support is no accident, you could do =
a lot of scripted s*** with that)

Another option would be to either call "sh -c"  or pipe the comma=
nd through krun (what will effectively do the same), use a --yesno or --war=
ningyesno dialog and " && kcmshell4 kwincompositing", but=
 KProcess cannot perform that logic operation (and we don want to runt that=
 as a child process, do we ;-)

On November 9th, 2012, 4:53 p.m., Martin Gr=C3=A4=C3=9Flin wrote= :

another k=
razy idea: open kcmchell4 kwincompositing with an additional flag which is =
interpreted by the KCM to show the appropriate message inline:

"Your viewport is foo bar, you can change in advanced tab to xrender o=
r disable"

On November 10th, 2012, 1:18 a.m., Thomas L=C3=BCbking wrote:

Cool idea.
Pitfalls:
- "don't ask again" case of the texture size limitation
- if the settings are already up, you won't (easily) get it to interpre=
t any arguments (the kcmodule isn't rebuilt)

On November 10th, 2012, 8:07 a.m., Martin Gr=C3=A4=C3=9Flin wrot= e:

- the &qu=
ot;don't ask again" part should be simple if we just store a confi=
g value
- DBus signals
ping.

do we want this (untranslated, ugly but better then nothing?) in 4.10?

- Thomas


On November 10th, 2012, 5:25 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated Nov. 10, 2012, 5:25 p.m.

Descripti= on 

The patch checks
1. whether the requested dimension is beyond the propagated viewport capabi=
lities (and in case toggles compositing with a sorry)
2. Because recently MESA is a bit enthusiastic about the capabilities, also=
 whether the requested dimension is beyond the propagated texture capabilit=
ies (and in case informs the user that this could or will lead to trouble, =
think of "maximized" windows)

Testing <= /h1> 
Constrained the limits to "5" and either dropped o=
ut of compositing with the dialog or got the information dialog. "Do n=
ot show again" works as well. Dialog code is largely stolen from usera=
ctions.cpp.

Diffs=

  • kwin/kcmkwin/kwincompositing/dbus.h (PRE-C= REATION)
  • kwin/kcmkwin/kwincompositing/main.h (35079= c3)
  • kwin/kcmkwin/kwincompositing/main.cpp (84a= 2895)
  • kwin/scene_opengl.h (57d99ec)
  • kwin/scene_opengl.cpp (4792c11)

View Diff
--===============8439747503189683986==-- --===============6390101056352438989== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============6390101056352438989==--