This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106917/

On November 8th, 2012, 7:24 p.m., Martin Gräßlin wrote:

can we somewhere tell the people where to change to XRender and how to suspend compositing?

On November 8th, 2012, 7:56 p.m., Thomas Lübking wrote:

What about auto-launching "kcmshell4 kwincompositing" and refer to the dialog?

On November 9th, 2012, 5:44 a.m., Martin Gräßlin wrote:

would be a solution. Could we embedd a link to open the KCM? I think that should be possible, shouldn't it.

One more concern is the tech speak. Maybe replace the GL_MAX_FOO by a description? I fear that the translators will not be able to do anything with it.

On November 9th, 2012, 3:48 p.m., Thomas Lübking wrote:

> Could we embedd a link to open the KCM?
Afaics: No. (not simply)
kdialog does not support active links (and i found no documented switch to alter that) and we cannot use a managed window.
So we'd have to introduce our own dialog executable or get a patch into kdialog (while i *guess* the lacking support is no accident, you could do a lot of scripted s*** with that)

Another option would be to either call "sh -c"  or pipe the command through krun (what will effectively do the same), use a --yesno or --warningyesno dialog and " && kcmshell4 kwincompositing", but KProcess cannot perform that logic operation (and we don want to runt that as a child process, do we ;-)

On November 9th, 2012, 4:53 p.m., Martin Gräßlin wrote:

another krazy idea: open kcmchell4 kwincompositing with an additional flag which is interpreted by the KCM to show the appropriate message inline:

"Your viewport is foo bar, you can change in advanced tab to xrender or disable"

On November 10th, 2012, 1:18 a.m., Thomas Lübking wrote:

Cool idea.
Pitfalls:
- "don't ask again" case of the texture size limitation
- if the settings are already up, you won't (easily) get it to interpret any arguments (the kcmodule isn't rebuilt)

On November 10th, 2012, 8:07 a.m., Martin Gräßlin wrote:

- the "don't ask again" part should be simple if we just store a config value
- DBus signals
ping.

do we want this (untranslated, ugly but better then nothing?) in 4.10?

- Thomas


On November 10th, 2012, 5:25 p.m., Thomas Lübking wrote:

Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Updated Nov. 10, 2012, 5:25 p.m.

Description

The patch checks
1. whether the requested dimension is beyond the propagated viewport capabilities (and in case toggles compositing with a sorry)
2. Because recently MESA is a bit enthusiastic about the capabilities, also whether the requested dimension is beyond the propagated texture capabilities (and in case informs the user that this could or will lead to trouble, think of "maximized" windows)

Testing

Constrained the limits to "5" and either dropped out of compositing with the dialog or got the information dialog. "Do not show again" works as well. Dialog code is largely stolen from useractions.cpp.

Diffs

  • kwin/kcmkwin/kwincompositing/dbus.h (PRE-CREATION)
  • kwin/kcmkwin/kwincompositing/main.h (35079c3)
  • kwin/kcmkwin/kwincompositing/main.cpp (84a2895)
  • kwin/scene_opengl.h (57d99ec)
  • kwin/scene_opengl.cpp (4792c11)

View Diff