[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: use synthetic configure notifications when needed
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-12-30 8:09:25
Message-ID: 20121230080925.14303.23225 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On None, Thomas Lübking wrote:
> >
give it another day to see whether it causes issues. It should enter before RC 2 \
tagging, though
> On None, Thomas Lübking wrote:
> > kwin/geometry.cpp, line 1868
> > <http://git.reviewboard.kde.org/r/108013/diff/1/?file=102885#file102885line1868>
> >
> > "yes"? ...
drop the comment?
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108013/#review24211
-----------------------------------------------------------
On Dec. 29, 2012, 9:44 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108013/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2012, 9:44 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> The notifications on resizes are required or gtk+ (and gtk3 as well) will either \
> not resize or lag internal updates etc. Qt is not affected, TK needs the \
> notification when leaving the move.
> On the other side it's not required at all to send them when just moving w/o \
> actually XMoveResize the window (apparently TK gives a shit on the geometry in the \
> notification, but only wants a trigger to then look up the position via Xlib or \
> whatever it will do there) and i'm willing to risk to say: also not when moving \
> otherwise (but only once when leaving the move)
>
> This addresses bug 312346.
> http://bugs.kde.org/show_bug.cgi?id=312346
>
>
> Diffs
> -----
>
> kwin/geometry.cpp 6a7ded4
>
> Diff: http://git.reviewboard.kde.org/r/108013/diff/
>
>
> Testing
> -------
>
> I tested a bunch of clients, like XMaxima (TK) gtk[3]-demo, chromium & google \
> earth, wine/notepad, some sdl games, mupdf (probably no toolkit), xterm and gvim \
> (aside kwrite, qupzilla, dolphin and whatever else i've open anyway) but would \
> llike to know and test some extra smart client actually reacting on move events (by \
> altering it's color or moving around some transient or so) - just that i don't know \
> one :-(
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108013/">http://git.reviewboard.kde.org/r/108013/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">give it another day to \
see whether it causes issues. It should enter before RC 2 tagging, though</pre> <br \
/>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On , <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108013/diff/1/?file=102885#file102885line1868" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/geometry.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Client::setGeometry(int x, int y, int w, int h, ForceGeometry_t force)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1868</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">// SELI </span><span class="cs">TODO</span><span class="c1"> \
won't this be too expensive?</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"yes"? \
...</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">drop the \
comment?</pre> <br />
<p>- Martin</p>
<br />
<p>On December 29th, 2012, 9:44 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2012, 9:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The notifications on resizes are required or gtk+ (and gtk3 as well) \
will either not resize or lag internal updates etc. Qt is not affected, TK needs the \
notification when leaving the move.
On the other side it's not required at all to send them when just moving w/o \
actually XMoveResize the window (apparently TK gives a shit on the geometry in the \
notification, but only wants a trigger to then look up the position via Xlib or \
whatever it will do there) and i'm willing to risk to say: also not when moving \
otherwise (but only once when leaving the move)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested a bunch of clients, like XMaxima (TK) gtk[3]-demo, chromium \
& google earth, wine/notepad, some sdl games, mupdf (probably no toolkit), xterm \
and gvim (aside kwrite, qupzilla, dolphin and whatever else i've open anyway) but \
would llike to know and test some extra smart client actually reacting on move events \
(by altering it's color or moving around some transient or so) - just that i \
don't know one :-(</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312346">312346</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/geometry.cpp <span style="color: grey">(6a7ded4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108013/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic