[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Splitting up of KWin's global D-Bus interface
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-08-30 20:28:41
Message-ID: 20120830202841.20480.26650 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106273/#review18292
-----------------------------------------------------------
kwin/dbusinterface.h
<http://git.reviewboard.kde.org/r/106273/#comment14464>
while at it: there should possibly be "setCompositing bool" instead/as =
well (so one does not have to check for the current state to toggle or not =
to achieve a certain state)
- Thomas L=C3=BCbking
On Aug. 30, 2012, 9:30 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106273/
> -----------------------------------------------------------
> =
> (Updated Aug. 30, 2012, 9:30 a.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> Two new interfaces are introduced:
> * org.kde.kwin.Compositing
> * org.kde.kwin.Effects
> =
> The Compositing interface is generated from scriptable elements on the
> KWin::Compositor class and the Compositor is exported as /Compositor.
> It provides the general Compositing related D-Bus methods like whether
> the compositor is active and toggling and so on.
> =
> The Effects interface is generated from scriptable elements on the
> KWin::EffectsHandlerImpl class and the instance is exported as /Effects.
> It provides all the effects related D-Bus methods like loading an effect
> or the list of all effects.
> =
> This removes the need to have all these methods provided on the global
> org.kde.KWin interface. For backwards compatibility they are kept, but
> no longer provided by the Workspace class. Instead a new DBusInterface
> is generated which wrapps the calls and delegates it to one of our three
> related Singleton objects:
> * Workspace
> * Compositor
> * EffectsHandlerImpl
> =
> =
> Diffs
> -----
> =
> kwin/CMakeLists.txt ce69e84 =
> kwin/composite.h a4a3710 =
> kwin/composite.cpp 640ebd6 =
> kwin/dbusinterface.h PRE-CREATION =
> kwin/dbusinterface.cpp PRE-CREATION =
> kwin/effects.h 8e67380 =
> kwin/effects.cpp cd7d7ee =
> kwin/org.kde.kwin.Compositing.xml PRE-CREATION =
> kwin/org.kde.kwin.Effects.xml PRE-CREATION =
> kwin/useractions.cpp c2778b6 =
> kwin/workspace.h 3f4bd9f =
> kwin/workspace.cpp e03e5e7 =
> =
> Diff: http://git.reviewboard.kde.org/r/106273/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106273/">http://git.reviewboard.kde.org/r/106273/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106273/diff/1/?file=82315#file82315line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/dbusinterface.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">public Q_SLOTS: // METHODS</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">103</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_NOREPLY</span> <span class="kt">void</span> <span \
class="n">toggleCompositing</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">while at \
it: there should possibly be "setCompositing bool" instead/as well (so one \
does not have to check for the current state to toggle or not to achieve a certain \
state)</pre> </div>
<br />
<p>- Thomas</p>
<br />
<p>On August 30th, 2012, 9:30 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2012, 9:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Two new interfaces are introduced:
* org.kde.kwin.Compositing
* org.kde.kwin.Effects
The Compositing interface is generated from scriptable elements on the
KWin::Compositor class and the Compositor is exported as /Compositor.
It provides the general Compositing related D-Bus methods like whether
the compositor is active and toggling and so on.
The Effects interface is generated from scriptable elements on the
KWin::EffectsHandlerImpl class and the instance is exported as /Effects.
It provides all the effects related D-Bus methods like loading an effect
or the list of all effects.
This removes the need to have all these methods provided on the global
org.kde.KWin interface. For backwards compatibility they are kept, but
no longer provided by the Workspace class. Instead a new DBusInterface
is generated which wrapps the calls and delegates it to one of our three
related Singleton objects:
* Workspace
* Compositor
* EffectsHandlerImpl</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/CMakeLists.txt <span style="color: grey">(ce69e84)</span></li>
<li>kwin/composite.h <span style="color: grey">(a4a3710)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(640ebd6)</span></li>
<li>kwin/dbusinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/dbusinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/effects.h <span style="color: grey">(8e67380)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(cd7d7ee)</span></li>
<li>kwin/org.kde.kwin.Compositing.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/org.kde.kwin.Effects.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(c2778b6)</span></li>
<li>kwin/workspace.h <span style="color: grey">(3f4bd9f)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(e03e5e7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106273/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic