From kwin Thu Aug 30 20:28:41 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Thu, 30 Aug 2012 20:28:41 +0000 To: kwin Subject: Re: Review Request: Splitting up of KWin's global D-Bus interface Message-Id: <20120830202841.20480.26650 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=134635853401297 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2793437279780214476==" --===============2793437279780214476== Content-Type: multipart/alternative; boundary="===============8178633482191628174==" --===============8178633482191628174== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106273/#review18292 ----------------------------------------------------------- kwin/dbusinterface.h while at it: there should possibly be "setCompositing bool" instead/as = well (so one does not have to check for the current state to toggle or not = to achieve a certain state) - Thomas L=C3=BCbking On Aug. 30, 2012, 9:30 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106273/ > ----------------------------------------------------------- > = > (Updated Aug. 30, 2012, 9:30 a.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > Two new interfaces are introduced: > * org.kde.kwin.Compositing > * org.kde.kwin.Effects > = > The Compositing interface is generated from scriptable elements on the > KWin::Compositor class and the Compositor is exported as /Compositor. > It provides the general Compositing related D-Bus methods like whether > the compositor is active and toggling and so on. > = > The Effects interface is generated from scriptable elements on the > KWin::EffectsHandlerImpl class and the instance is exported as /Effects. > It provides all the effects related D-Bus methods like loading an effect > or the list of all effects. > = > This removes the need to have all these methods provided on the global > org.kde.KWin interface. For backwards compatibility they are kept, but > no longer provided by the Workspace class. Instead a new DBusInterface > is generated which wrapps the calls and delegates it to one of our three > related Singleton objects: > * Workspace > * Compositor > * EffectsHandlerImpl > = > = > Diffs > ----- > = > kwin/CMakeLists.txt ce69e84 = > kwin/composite.h a4a3710 = > kwin/composite.cpp 640ebd6 = > kwin/dbusinterface.h PRE-CREATION = > kwin/dbusinterface.cpp PRE-CREATION = > kwin/effects.h 8e67380 = > kwin/effects.cpp cd7d7ee = > kwin/org.kde.kwin.Compositing.xml PRE-CREATION = > kwin/org.kde.kwin.Effects.xml PRE-CREATION = > kwin/useractions.cpp c2778b6 = > kwin/workspace.h 3f4bd9f = > kwin/workspace.cpp e03e5e7 = > = > Diff: http://git.reviewboard.kde.org/r/106273/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============8178633482191628174== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106273/

= =

kwin/dbusinterface.h (Diff revision 1)
	public Q_SLOTS: // METHODS
		103	Q_NOREPLY void toggleCompositing();

while at it: there should possibly be "setCompositing bool"=
; instead/as well (so one does not have to check for the current state to t=
oggle or not to achieve a certain state)

- Thomas

On August 30th, 2012, 9:30 a.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.

By Martin Gr=C3=A4=C3=9Flin.

Updated Aug. 30, 2012, 9:30 a.m.

Descripti= on

Two new interfaces are introduced:
* org.kde.kwin.Compositing
* org.kde.kwin.Effects

The Compositing interface is generated from scriptable elements on the
KWin::Compositor class and the Compositor is exported as /Compositor.
It provides the general Compositing related D-Bus methods like whether
the compositor is active and toggling and so on.

The Effects interface is generated from scriptable elements on the
KWin::EffectsHandlerImpl class and the instance is exported as /Effects.
It provides all the effects related D-Bus methods like loading an effect
or the list of all effects.

This removes the need to have all these methods provided on the global
org.kde.KWin interface. For backwards compatibility they are kept, but
no longer provided by the Workspace class. Instead a new DBusInterface
is generated which wrapps the calls and delegates it to one of our three
related Singleton objects:
* Workspace
* Compositor
* EffectsHandlerImpl

Diffs=

kwin/CMakeLists.txt (ce69e84)
kwin/composite.h (a4a3710)
kwin/composite.cpp (640ebd6)
kwin/dbusinterface.h (PRE-CREATION)=
kwin/dbusinterface.cpp (PRE-CREATION)
kwin/effects.h (8e67380)
kwin/effects.cpp (cd7d7ee)
kwin/org.kde.kwin.Compositing.xml (PRE-CRE= ATION)
kwin/org.kde.kwin.Effects.xml (PRE-CREATIO= N)
kwin/useractions.cpp (c2778b6)
kwin/workspace.h (3f4bd9f)
kwin/workspace.cpp (e03e5e7)

--===============8178633482191628174==-- --===============2793437279780214476== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2793437279780214476==--