This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106273/

kwin/dbusinterface.h (Diff revision 1)
public Q_SLOTS: // METHODS
103
    Q_NOREPLY void toggleCompositing();
while at it: there should possibly be "setCompositing bool" instead/as well (so one does not have to check for the current state to toggle or not to achieve a certain state)

- Thomas


On August 30th, 2012, 9:30 a.m., Martin Gräßlin wrote:

Review request for kwin.
By Martin Gräßlin.

Updated Aug. 30, 2012, 9:30 a.m.

Description

Two new interfaces are introduced:
* org.kde.kwin.Compositing
* org.kde.kwin.Effects

The Compositing interface is generated from scriptable elements on the
KWin::Compositor class and the Compositor is exported as /Compositor.
It provides the general Compositing related D-Bus methods like whether
the compositor is active and toggling and so on.

The Effects interface is generated from scriptable elements on the
KWin::EffectsHandlerImpl class and the instance is exported as /Effects.
It provides all the effects related D-Bus methods like loading an effect
or the list of all effects.

This removes the need to have all these methods provided on the global
org.kde.KWin interface. For backwards compatibility they are kept, but
no longer provided by the Workspace class. Instead a new DBusInterface
is generated which wrapps the calls and delegates it to one of our three
related Singleton objects:
* Workspace
* Compositor
* EffectsHandlerImpl

Diffs

  • kwin/CMakeLists.txt (ce69e84)
  • kwin/composite.h (a4a3710)
  • kwin/composite.cpp (640ebd6)
  • kwin/dbusinterface.h (PRE-CREATION)
  • kwin/dbusinterface.cpp (PRE-CREATION)
  • kwin/effects.h (8e67380)
  • kwin/effects.cpp (cd7d7ee)
  • kwin/org.kde.kwin.Compositing.xml (PRE-CREATION)
  • kwin/org.kde.kwin.Effects.xml (PRE-CREATION)
  • kwin/useractions.cpp (c2778b6)
  • kwin/workspace.h (3f4bd9f)
  • kwin/workspace.cpp (e03e5e7)

View Diff