This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106088/ 

This review has been submitted with commit cc4fa37d22092e98b3d77fd1f3dd8ad752bb9879 by Martin Gräßlin to branch KDE/4.9.

- Commit


On August 25th, 2012, 11:30 a.m., Martin Gräßlin wrote:

Review request for kwin.
By Martin Gräßlin.

Updated Aug. 25, 2012, 11:30 a.m.

Description 

Use the first client as entrance to the focus chain if no active window

The recently used mode of TabBox uses the active window as the entrance
into the focus chain. If there is no active window it does not find any
Clients. To solve this issue the ClientModel now uses the first entry
of the focus chain in case there is no active window.

BUG: 305449
FIXED-IN: 4.9.1
Bugs: 305449

Diffs

  • kwin/tabbox/tests/test_tabbox_clientmodel.cpp (cd2c963)
  • kwin/tabbox/tests/test_tabbox_clientmodel.h (1bdf0d4)
  • kwin/tabbox/tests/mock_tabboxhandler.cpp (1d27dc7)
  • kwin/tabbox/tests/mock_tabboxhandler.h (f13a820)
  • kwin/tabbox/tabboxhandler.h (976f201)
  • kwin/tabbox/clientmodel.cpp (b78c1f5)
  • kwin/tabbox/tabbox.h (bf69ad9)
  • kwin/tabbox/tabbox.cpp (098d759)

View Diff