[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request: Declarative DesktopThumbnailItem to render desktop thumbnails
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-03-29 18:29:36
Message-ID: 20120329182936.20581.62697 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104441/
-----------------------------------------------------------
Review request for kwin.
Description
-------
Adding a new DesktopThumbnailItem to render a desktop thumbnail. It is integrated \
into the Effect System like the WindowThumbnailItem and the code got a little bit \
refactored for that (which might make the diff difficult to read - if needed I can \
upload smaller chunks I have in my git branch).
To render the desktop thumbnail a new effect hook "paintDesktop" is added which \
performs a paintScreen but ensures that only the windows which are on the desktop to \
paint will be rendered. It's currently not yet exported to the Effects but might make \
sense for those effects rendering the desktops multiple times (e.g. cube).
There is still some interference with Windows rendered afterwards and blur effect - \
will investigate.
This addresses bug 296067.
http://bugs.kde.org/show_bug.cgi?id=296067
Diffs
-----
kwin/effects.h 994a89c
kwin/effects.cpp 8e73780
kwin/kcmkwin/kwintabbox/layoutconfig.cpp b2a4266
kwin/kcmkwin/kwintabbox/thumbnailitem.h 04977d6
kwin/kcmkwin/kwintabbox/thumbnailitem.cpp d65c30c
kwin/scene.cpp 4e69121
kwin/scripting/scripting.cpp b5b1a2e
kwin/tabbox/declarative.cpp c8abf60
kwin/thumbnailitem.h a219a33
kwin/thumbnailitem.cpp b2685be
Diff: http://git.reviewboard.kde.org/r/104441/diff/
Testing
-------
see attached screenshot and example code: http://paste.kde.org/448688
Screenshots
-----------
Desktop Thumbnails as by the example code
http://git.reviewboard.kde.org/r/104441/s/499/
Thanks,
Martin Gräßlin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104441/">http://git.reviewboard.kde.org/r/104441/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding a new DesktopThumbnailItem to render a desktop thumbnail. It is \
integrated into the Effect System like the WindowThumbnailItem and the code got a \
little bit refactored for that (which might make the diff difficult to read - if \
needed I can upload smaller chunks I have in my git branch).
To render the desktop thumbnail a new effect hook "paintDesktop" is added \
which performs a paintScreen but ensures that only the windows which are on the \
desktop to paint will be rendered. It's currently not yet exported to the Effects \
but might make sense for those effects rendering the desktops multiple times (e.g. \
cube).
There is still some interference with Windows rendered afterwards and blur effect - \
will investigate.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see attached screenshot and example code: \
http://paste.kde.org/448688</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=296067">296067</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.h <span style="color: grey">(994a89c)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(8e73780)</span></li>
<li>kwin/kcmkwin/kwintabbox/layoutconfig.cpp <span style="color: \
grey">(b2a4266)</span></li>
<li>kwin/kcmkwin/kwintabbox/thumbnailitem.h <span style="color: \
grey">(04977d6)</span></li>
<li>kwin/kcmkwin/kwintabbox/thumbnailitem.cpp <span style="color: \
grey">(d65c30c)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(4e69121)</span></li>
<li>kwin/scripting/scripting.cpp <span style="color: grey">(b5b1a2e)</span></li>
<li>kwin/tabbox/declarative.cpp <span style="color: grey">(c8abf60)</span></li>
<li>kwin/thumbnailitem.h <span style="color: grey">(a219a33)</span></li>
<li>kwin/thumbnailitem.cpp <span style="color: grey">(b2685be)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104441/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104441/s/499/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/29/desktop-thumbnails_400x100.png" \
style="border: 1px black solid;" alt="Desktop Thumbnails as by the example code" \
/></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic