From kwin Thu Mar 29 18:29:36 2012 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Thu, 29 Mar 2012 18:29:36 +0000 To: kwin Subject: Review Request: Declarative DesktopThumbnailItem to render desktop thumbnails Message-Id: <20120329182936.20581.62697 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=133304586317090 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8439700156765213366==" --===============8439700156765213366== Content-Type: multipart/alternative; boundary="===============4591393438539379957==" --===============4591393438539379957== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104441/ ----------------------------------------------------------- Review request for kwin. Description ------- Adding a new DesktopThumbnailItem to render a desktop thumbnail. It is inte= grated into the Effect System like the WindowThumbnailItem and the code got= a little bit refactored for that (which might make the diff difficult to r= ead - if needed I can upload smaller chunks I have in my git branch). To render the desktop thumbnail a new effect hook "paintDesktop" is added w= hich performs a paintScreen but ensures that only the windows which are on = the desktop to paint will be rendered. It's currently not yet exported to t= he Effects but might make sense for those effects rendering the desktops mu= ltiple times (e.g. cube). There is still some interference with Windows rendered afterwards and blur = effect - will investigate. This addresses bug 296067. http://bugs.kde.org/show_bug.cgi?id=3D296067 Diffs ----- kwin/effects.h 994a89c = kwin/effects.cpp 8e73780 = kwin/kcmkwin/kwintabbox/layoutconfig.cpp b2a4266 = kwin/kcmkwin/kwintabbox/thumbnailitem.h 04977d6 = kwin/kcmkwin/kwintabbox/thumbnailitem.cpp d65c30c = kwin/scene.cpp 4e69121 = kwin/scripting/scripting.cpp b5b1a2e = kwin/tabbox/declarative.cpp c8abf60 = kwin/thumbnailitem.h a219a33 = kwin/thumbnailitem.cpp b2685be = Diff: http://git.reviewboard.kde.org/r/104441/diff/ Testing ------- see attached screenshot and example code: http://paste.kde.org/448688 Screenshots ----------- Desktop Thumbnails as by the example code http://git.reviewboard.kde.org/r/104441/s/499/ Thanks, Martin Gr=C3=A4=C3=9Flin --===============4591393438539379957== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104441/

Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.

Descripti= on 

Adding a new DesktopThumbnailItem to render a desktop thumbn=
ail. It is integrated into the Effect System like the WindowThumbnailItem a=
nd the code got a little bit refactored for that (which might make the diff=
 difficult to read - if needed I can upload smaller chunks I have in my git=
 branch).

To render the desktop thumbnail a new effect hook "paintDesktop" =
is added which performs a paintScreen but ensures that only the windows whi=
ch are on the desktop to paint will be rendered. It's currently not yet=
 exported to the Effects but might make sense for those effects rendering t=
he desktops multiple times (e.g. cube).

There is still some interference with Windows rendered afterwards and blur =
effect - will investigate.

Testing <= /h1> 
see attached screenshot and example code: http://paste.kde.o=
rg/448688
Bugs: 296067

Diffs=

  • kwin/effects.h (994a89c)
  • kwin/effects.cpp (8e73780)
  • kwin/kcmkwin/kwintabbox/layoutconfig.cpp (= b2a4266)
  • kwin/kcmkwin/kwintabbox/thumbnailitem.h (0= 4977d6)
  • kwin/kcmkwin/kwintabbox/thumbnailitem.cpp = (d65c30c)
  • kwin/scene.cpp (4e69121)
  • kwin/scripting/scripting.cpp (b5b1a2e)
  • kwin/tabbox/declarative.cpp (c8abf60)
  • kwin/thumbnailitem.h (a219a33)
  • kwin/thumbnailitem.cpp (b2685be)

View Diff

Screensho= ts

3D"Desktop
--===============4591393438539379957==-- --===============8439700156765213366== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============8439700156765213366==--