This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104441/

Review request for kwin.
By Martin Gräßlin.

Description

Adding a new DesktopThumbnailItem to render a desktop thumbnail. It is integrated into the Effect System like the WindowThumbnailItem and the code got a little bit refactored for that (which might make the diff difficult to read - if needed I can upload smaller chunks I have in my git branch).

To render the desktop thumbnail a new effect hook "paintDesktop" is added which performs a paintScreen but ensures that only the windows which are on the desktop to paint will be rendered. It's currently not yet exported to the Effects but might make sense for those effects rendering the desktops multiple times (e.g. cube).

There is still some interference with Windows rendered afterwards and blur effect - will investigate.

Testing

see attached screenshot and example code: http://paste.kde.org/448688
Bugs: 296067

Diffs

  • kwin/effects.h (994a89c)
  • kwin/effects.cpp (8e73780)
  • kwin/kcmkwin/kwintabbox/layoutconfig.cpp (b2a4266)
  • kwin/kcmkwin/kwintabbox/thumbnailitem.h (04977d6)
  • kwin/kcmkwin/kwintabbox/thumbnailitem.cpp (d65c30c)
  • kwin/scene.cpp (4e69121)
  • kwin/scripting/scripting.cpp (b5b1a2e)
  • kwin/tabbox/declarative.cpp (c8abf60)
  • kwin/thumbnailitem.h (a219a33)
  • kwin/thumbnailitem.cpp (b2685be)

View Diff

Screenshots

Desktop Thumbnails as by the example code