[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: install update scripts only on desktop
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-02-29 15:46:34
Message-ID: 20120229154634.17571.82509 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 27, 2012, 8:21 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > I fear we will run into issues with this approach when we have to do up=
dates to kwin which affects both PA and desktop. If you consider that updat=
ing on PA is never a usecase, I'm fine with it. Otherwise I would prefer to=
fix the real issue by not installing the offending update rule.
> > =
> > A different solution would be to install a kwinrc with the settings alr=
eady there to not run the update script.
> > =
> > Unrelated side note: I think it's time to drop a few update scripts... =
that is everything from KDE 3 and early 4.x
> =
> Marco Martin wrote:
> i can change the cmakelist to install file by file if preferred ;)
> =
> Thomas L=C3=BCbking wrote:
> What about having one update script calling all others, which can at =
runtime determine the target system and select updates to apply or not?
or, data could become desktopupdatescripts and have another one mobileupdat=
escripts, but then a script can not be valid for both
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104097/#review10964
-----------------------------------------------------------
On Feb. 27, 2012, 4:54 p.m., Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104097/
> -----------------------------------------------------------
> =
> (Updated Feb. 27, 2012, 4:54 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> on profiles different from desktop those update scripts not only don't ha=
ve meaning but can even break stuff (it sets the tabbox plugin on the wrong=
default, that is different on mobile)
> =
> =
> Diffs
> -----
> =
> kwin/CMakeLists.txt cba139b =
> =
> Diff: http://git.reviewboard.kde.org/r/104097/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104097/">http://git.reviewboard.kde.org/r/104097/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 27th, 2012, 8:21 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I fear we will run into issues with this approach when we have to do \
updates to kwin which affects both PA and desktop. If you consider that updating on \
PA is never a usecase, I'm fine with it. Otherwise I would prefer to fix the real \
issue by not installing the offending update rule.
A different solution would be to install a kwinrc with the settings already there to \
not run the update script.
Unrelated side note: I think it's time to drop a few update scripts... that is \
everything from KDE 3 and early 4.x</pre> </blockquote>
<p>On February 27th, 2012, 9:23 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i can change the \
cmakelist to install file by file if preferred ;)</pre> </blockquote>
<p>On February 27th, 2012, 9:40 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about having one \
update script calling all others, which can at runtime determine the target system \
and select updates to apply or not?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">or, data could become \
desktopupdatescripts and have another one mobileupdatescripts, but then a script can \
not be valid for both</pre> <br />
<p>- Marco</p>
<br />
<p>On February 27th, 2012, 4:54 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2012, 4:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">on profiles different from desktop those update scripts not only \
don't have meaning but can even break stuff (it sets the tabbox plugin on the \
wrong default, that is different on mobile)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/CMakeLists.txt <span style="color: grey">(cba139b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104097/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic