From kwin Wed Feb 29 15:46:34 2012 From: "Marco Martin" Date: Wed, 29 Feb 2012 15:46:34 +0000 To: kwin Subject: Re: Review Request: install update scripts only on desktop Message-Id: <20120229154634.17571.82509 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=133053043630642 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4528308762612775561==" --===============4528308762612775561== Content-Type: multipart/alternative; boundary="===============9017117154493273546==" --===============9017117154493273546== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Feb. 27, 2012, 8:21 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > I fear we will run into issues with this approach when we have to do up= dates to kwin which affects both PA and desktop. If you consider that updat= ing on PA is never a usecase, I'm fine with it. Otherwise I would prefer to= fix the real issue by not installing the offending update rule. > > = > > A different solution would be to install a kwinrc with the settings alr= eady there to not run the update script. > > = > > Unrelated side note: I think it's time to drop a few update scripts... = that is everything from KDE 3 and early 4.x > = > Marco Martin wrote: > i can change the cmakelist to install file by file if preferred ;) > = > Thomas L=C3=BCbking wrote: > What about having one update script calling all others, which can at = runtime determine the target system and select updates to apply or not? or, data could become desktopupdatescripts and have another one mobileupdat= escripts, but then a script can not be valid for both - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104097/#review10964 ----------------------------------------------------------- On Feb. 27, 2012, 4:54 p.m., Marco Martin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104097/ > ----------------------------------------------------------- > = > (Updated Feb. 27, 2012, 4:54 p.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > on profiles different from desktop those update scripts not only don't ha= ve meaning but can even break stuff (it sets the tabbox plugin on the wrong= default, that is different on mobile) > = > = > Diffs > ----- > = > kwin/CMakeLists.txt cba139b = > = > Diff: http://git.reviewboard.kde.org/r/104097/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Marco Martin > = > --===============9017117154493273546== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104097/

On February 27th, 2012, 8:21 p.m., Martin G= r=C3=A4=C3=9Flin wrote:

I fear we=
 will run into issues with this approach when we have to do updates to kwin=
 which affects both PA and desktop. If you consider that updating on PA is =
never a usecase, I'm fine with it. Otherwise I would prefer to fix the =
real issue by not installing the offending update rule.

A different solution would be to install a kwinrc with the settings already=
 there to not run the update script.

Unrelated side note: I think it's time to drop a few update scripts... =
that is everything from KDE 3 and early 4.x

On February 27th, 2012, 9:23 p.m., Marco Martin wrote:

i can cha=
nge the cmakelist to install file by file if preferred ;)

On February 27th, 2012, 9:40 p.m., Thomas L=C3=BCbking wrote:

What abou=
t having one update script calling all others, which can at runtime determi=
ne the target system and select updates to apply or not?
or, data co=
uld become desktopupdatescripts and have another one mobileupdatescripts, b=
ut then a script can not be valid for both

- Marco


On February 27th, 2012, 4:54 p.m., Marco Martin wrote:

Review request for kwin.
By Marco Martin.

Updated Feb. 27, 2012, 4:54 p.m.

Descripti= on 

on profiles different from desktop those update scripts not =
only don't have meaning but can even break stuff (it sets the tabbox pl=
ugin on the wrong default, that is different on mobile)

Diffs=

  • kwin/CMakeLists.txt (cba139b)

View Diff
--===============9017117154493273546==-- --===============4528308762612775561== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============4528308762612775561==--