This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104097/

On February 27th, 2012, 8:21 p.m., Martin Gräßlin wrote:

I fear we will run into issues with this approach when we have to do updates to kwin which affects both PA and desktop. If you consider that updating on PA is never a usecase, I'm fine with it. Otherwise I would prefer to fix the real issue by not installing the offending update rule.

A different solution would be to install a kwinrc with the settings already there to not run the update script.

Unrelated side note: I think it's time to drop a few update scripts... that is everything from KDE 3 and early 4.x

On February 27th, 2012, 9:23 p.m., Marco Martin wrote:

i can change the cmakelist to install file by file if preferred ;)

On February 27th, 2012, 9:40 p.m., Thomas Lübking wrote:

What about having one update script calling all others, which can at runtime determine the target system and select updates to apply or not?
or, data could become desktopupdatescripts and have another one mobileupdatescripts, but then a script can not be valid for both

- Marco


On February 27th, 2012, 4:54 p.m., Marco Martin wrote:

Review request for kwin.
By Marco Martin.

Updated Feb. 27, 2012, 4:54 p.m.

Description

on profiles different from desktop those update scripts not only don't have meaning but can even break stuff (it sets the tabbox plugin on the wrong default, that is different on mobile)

Diffs

  • kwin/CMakeLists.txt (cba139b)

View Diff