[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: invoke XFree86-VidModeExtension to determine refresh
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-02-29 14:27:53
Message-ID: 20120229142753.6416.90354 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104110/#review11019
-----------------------------------------------------------
I'm not sure whether this is 4.8 material. I could imagine that distros are not happy \
about that and dependency freeze is clearly passed. So I would say it can only go to \
master.
kwin/CMakeLists.txt
<http://git.reviewboard.kde.org/r/104110/#comment8935>
you don't need the else, the define will just not be set
- Martin Gräßlin
On Feb. 28, 2012, 10:08 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104110/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2012, 10:08 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> =)
> I never got usable modelines then, now i know a lot about this stuff and it's \
> mostly useless. Crap.
> Tested on a CRT (85Hz) and a TFT (60Hz), both work as expected, ie. the value is \
> correctly determined. I left the -i18n downforcing updated- nvidia-settings query \
> as a failsafe and put the usage into #ifdefs so it's not mandatory.
> Also we have to link another lib (conditionally in CMake as well) - no idea whether \
> this would harm 4.8 qualification.
>
> Diffs
> -----
>
> kwin/CMakeLists.txt 215e69f
> kwin/options.cpp d496569
>
> Diff: http://git.reviewboard.kde.org/r/104110/diff/
>
>
> Testing
> -------
>
> Yes, see kDebug() statements
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104110/">http://git.reviewboard.kde.org/r/104110/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure whether \
this is 4.8 material. I could imagine that distros are not happy about that and \
dependency freeze is clearly passed. So I would say it can only go to master.</pre> \
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104110/diff/1/?file=51277#file51277line199" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">199</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">else(XF86VM_LIBRARY)</pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">200</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
add_definitions(-DKWIN_HAVE_XF86VM=0)</pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">201</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">endif(XF86VM_LIBRARY)</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you \
don't need the else, the define will just not be set</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On February 28th, 2012, 10:08 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2012, 10:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">=) I never got usable modelines then, now i know a lot about this stuff \
and it's mostly useless. Crap.
Tested on a CRT (85Hz) and a TFT (60Hz), both work as expected, ie. the value is \
correctly determined. I left the -i18n downforcing updated- nvidia-settings query as \
a failsafe and put the usage into #ifdefs so it's not mandatory.
Also we have to link another lib (conditionally in CMake as well) - no idea whether \
this would harm 4.8 qualification.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, see kDebug() statements</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/CMakeLists.txt <span style="color: grey">(215e69f)</span></li>
<li>kwin/options.cpp <span style="color: grey">(d496569)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104110/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic