--===============0254644212579064000== Content-Type: multipart/alternative; boundary="===============2474316921401442881==" --===============2474316921401442881== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104110/#review11019 ----------------------------------------------------------- I'm not sure whether this is 4.8 material. I could imagine that distros are= not happy about that and dependency freeze is clearly passed. So I would s= ay it can only go to master. kwin/CMakeLists.txt you don't need the else, the define will just not be set - Martin Gr=C3=A4=C3=9Flin On Feb. 28, 2012, 10:08 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104110/ > ----------------------------------------------------------- > = > (Updated Feb. 28, 2012, 10:08 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > =3D) > I never got usable modelines then, now i know a lot about this stuff and = it's mostly useless. Crap. > = > Tested on a CRT (85Hz) and a TFT (60Hz), both work as expected, ie. the v= alue is correctly determined. > I left the -i18n downforcing updated- nvidia-settings query as a failsafe= and put the usage into #ifdefs so it's not mandatory. > = > Also we have to link another lib (conditionally in CMake as well) - no id= ea whether this would harm 4.8 qualification. > = > = > Diffs > ----- > = > kwin/CMakeLists.txt 215e69f = > kwin/options.cpp d496569 = > = > Diff: http://git.reviewboard.kde.org/r/104110/diff/ > = > = > Testing > ------- > = > Yes, see kDebug() statements > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============2474316921401442881== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104110/

I'm no=
t sure whether this is 4.8 material. I could imagine that distros are not h=
appy about that and dependency freeze is clearly passed. So I would say it =
can only go to master.

= =

kwin/CMakeLists.txt (Diff revision 1)

		199	else(XF86VM_LIBRARY)
		200	add_definitions(-DKWIN_HAVE_XF86VM=3D0)
		201	endif(XF86VM_LIBRARY)

you don't need the else, the define will just not be set

- Martin

On February 28th, 2012, 10:08 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

By Thomas L=C3=BCbking.

Updated Feb. 28, 2012, 10:08 p.m.

Descripti= on

=3D)
I never got usable modelines then, now i know a lot about this stuff and it=
's mostly useless. Crap.

Tested on a CRT (85Hz) and a TFT (60Hz), both work as expected, ie. the val=
ue is correctly determined.
I left the -i18n downforcing updated- nvidia-settings query as a failsafe a=
nd put the usage into #ifdefs so it's not mandatory.

Also we have to link another lib (conditionally in CMake as well) - no idea=
 whether this would harm 4.8 qualification.

Testing <= /h1>

Yes, see kDebug() statements

Diffs=

kwin/CMakeLists.txt (215e69f)
kwin/options.cpp (d496569)

--===============2474316921401442881==-- --===============0254644212579064000== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============0254644212579064000==--