This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104110/ 

I'm not sure whether this is 4.8 material. I could imagine that distros are not happy about that and dependency freeze is clearly passed. So I would say it can only go to master.

kwin/CMakeLists.txt (Diff revision 1) 


  

 




 
 



 

  

    
    

    199
    
else(XF86VM_LIBRARY)

  


  

    
    

    200
    
    add_definitions(-DKWIN_HAVE_XF86VM=0)

  


  

    
    

    201
    
endif(XF86VM_LIBRARY)

  


 





you don't need the else, the define will just not be set









- Martin






On February 28th, 2012, 10:08 p.m., Thomas Lübking wrote:









 

  


Review request for kwin and Martin Gräßlin.


By Thomas Lübking.




Updated Feb. 28, 2012, 10:08 p.m.








Description 

 

 

  
   
=)
I never got usable modelines then, now i know a lot about this stuff and it's mostly useless. Crap.

Tested on a CRT (85Hz) and a TFT (60Hz), both work as expected, ie. the value is correctly determined.
I left the -i18n downforcing updated- nvidia-settings query as a failsafe and put the usage into #ifdefs so it's not mandatory.

Also we have to link another lib (conditionally in CMake as well) - no idea whether this would harm 4.8 qualification.

  		
 






Testing 



 

  
   
Yes, see kDebug() statements

  		
 








Diffs 


    

 
  • kwin/CMakeLists.txt (215e69f)
    • 

 
  • kwin/options.cpp (d496569)
    • 





View Diff