[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Hotfix the translucency effect
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-02-26 17:17:53
Message-ID: 20120226171753.626.43640 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104083/#review10916
-----------------------------------------------------------
Ship it!
I agree that it should be rewritten - already had it in my mind. Reminds me=
to finish off the JS bindings ;-)
- Martin Gr=C3=A4=C3=9Flin
On Feb. 26, 2012, 5:09 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104083/
> -----------------------------------------------------------
> =
> (Updated Feb. 26, 2012, 5:09 p.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> it doesn't sufficiently manage the opacity flag.
> in general the effect isn't capable of handling colliding animation, so i=
t should be rewritten to the animationeffect - in doubt on JS - for 4.9
> =
> =
> Diffs
> -----
> =
> kwin/effects/translucency/translucency.cpp 4e6d58d =
> =
> Diff: http://git.reviewboard.kde.org/r/104083/diff/
> =
> =
> Testing
> -------
> =
> w/ slow transitions (5s) the opacity snapback of the client is obvious - =
gone with the patch.
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104083/">http://git.reviewboard.kde.org/r/104083/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree that it should \
be rewritten - already had it in my mind. Reminds me to finish off the JS bindings \
;-)</pre> <br />
<p>- Martin</p>
<br />
<p>On February 26th, 2012, 5:09 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2012, 5:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it doesn't sufficiently manage the opacity flag. in general the \
effect isn't capable of handling colliding animation, so it should be rewritten \
to the animationeffect - in doubt on JS - for 4.9</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">w/ slow transitions (5s) the opacity snapback of the client is obvious - \
gone with the patch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/translucency/translucency.cpp <span style="color: \
grey">(4e6d58d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104083/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic