This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104083/

Ship it!

I agree that it should be rewritten - already had it in my mind. Reminds me to finish off the JS bindings ;-)

- Martin


On February 26th, 2012, 5:09 p.m., Thomas Lübking wrote:

Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Updated Feb. 26, 2012, 5:09 p.m.

Description 

it doesn't sufficiently manage the opacity flag.
in general the effect isn't capable of handling colliding animation, so it should be rewritten to the animationeffect - in doubt on JS - for 4.9

Testing 

w/ slow transitions (5s) the opacity snapback of the client is obvious - gone with the patch.

Diffs

  • kwin/effects/translucency/translucency.cpp (4e6d58d)

View Diff