--===============2555930261414501146== Content-Type: multipart/alternative; boundary="===============2963482044961355010==" --===============2963482044961355010== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104083/#review10916 ----------------------------------------------------------- Ship it! I agree that it should be rewritten - already had it in my mind. Reminds me= to finish off the JS bindings ;-) - Martin Gr=C3=A4=C3=9Flin On Feb. 26, 2012, 5:09 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104083/ > ----------------------------------------------------------- > = > (Updated Feb. 26, 2012, 5:09 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > it doesn't sufficiently manage the opacity flag. > in general the effect isn't capable of handling colliding animation, so i= t should be rewritten to the animationeffect - in doubt on JS - for 4.9 > = > = > Diffs > ----- > = > kwin/effects/translucency/translucency.cpp 4e6d58d = > = > Diff: http://git.reviewboard.kde.org/r/104083/diff/ > = > = > Testing > ------- > = > w/ slow transitions (5s) the opacity snapback of the client is obvious - = gone with the patch. > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============2963482044961355010== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104083/

Ship it!

I agree th=
at it should be rewritten - already had it in my mind. Reminds me to finish=
 off the JS bindings ;-)

- Martin


On February 26th, 2012, 5:09 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated Feb. 26, 2012, 5:09 p.m.

Descripti= on 

it doesn't sufficiently manage the opacity flag.
in general the effect isn't capable of handling colliding animation, so=
 it should be rewritten to the animationeffect - in doubt on JS - for 4.9

Testing <= /h1> 
w/ slow transitions (5s) the opacity snapback of the client =
is obvious - gone with the patch.

Diffs=

  • kwin/effects/translucency/translucency.cpp (4e6d58d)

View Diff
--===============2963482044961355010==-- --===============2555930261414501146== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2555930261414501146==--