From kwin Fri Jan 20 02:21:57 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Fri, 20 Jan 2012 02:21:57 +0000 To: kwin Subject: Re: Review Request: Delay added signal and other signal bindings for synced windows until the window Message-Id: <20120120022157.15360.88210 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=132702629832726 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6840194890985477658==" --===============6840194890985477658== Content-Type: multipart/alternative; boundary="===============3871762945063601809==" --===============3871762945063601809== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103742/ ----------------------------------------------------------- (Updated Jan. 20, 2012, 2:21 a.m.) Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Philipp Knechtges. Changes ------- Forgot that the damageEvent is the only trigger for clients not supporting = the XSYNC extension ... Description ------- see summary. Makes animations smoother and would have prevented RR http://g= it.reviewboard.kde.org/r/103733 ;-) I'll keep it in my personal 4.8 branch and therefore won't care about wheth= er it's applied to 4.8.n or 4.9 :-P Diffs (updated) ----- kwin/client.cpp 520ed85 = kwin/composite.cpp 55a7144 = kwin/effects.h f4ad2fb = kwin/effects.cpp 6c252c9 = kwin/events.cpp 26e0139 = kwin/toplevel.h 693e6f3 = kwin/toplevel.cpp ffe7f0c = Diff: http://git.reviewboard.kde.org/r/103742/diff/diff Testing ------- generic animations still work - better ;-) Thanks, Thomas L=C3=BCbking --===============3871762945063601809== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103742/

Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Philipp Knechtge= s.
By Thomas L=C3=BCbking.

Updated Jan. 20, 2012, 2:21 a.m.

Changes 
Forgot that the damageEvent is the only trigger for clients =
not supporting the XSYNC extension ...

Descripti= on 

see summary. Makes animations smoother and would have preven=
ted RR http://git.reviewboard.kde.org/r/103733 ;-)

I'll keep it in my personal 4.8 branch and therefore won't care abo=
ut whether it's applied to 4.8.n or 4.9 :-P

Testing <= /h1> 
generic animations still work - better ;-)

Diffs= (updated)

  • kwin/client.cpp (520ed85)
  • kwin/composite.cpp (55a7144)
  • kwin/effects.h (f4ad2fb)
  • kwin/effects.cpp (6c252c9)
  • kwin/events.cpp (26e0139)
  • kwin/toplevel.h (693e6f3)
  • kwin/toplevel.cpp (ffe7f0c)

View Diff
--===============3871762945063601809==-- --===============6840194890985477658== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============6840194890985477658==--