[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: fixing high cpu usage bugs
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-01-19 15:27:14
Message-ID: 20120119152714.18335.47418 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 19, 2012, 2:38 p.m., Commit Hook wrote:
> > This review has been submitted with commit \
> > d07964e0af95911a97c3f474b694570cb279878c by Philipp Knechtges to branch KDE/4.8.
>
> Thomas Lübking wrote:
> a) Sorry for being late
> b) Good catch!
> c) While a securing mechanism is inevitable, the ultimate source of the issue is \
> that we emit signals like esp "windowAdded" and "windowClosed" to windows not being \
> ready for painting - what is a lie (the window doesn't appear or hide, and \
> pre-sending "windowAdded" causes visual breaks of show animations. d) I knew there \
> was sth. left i wanted to do before 4.8... :-\ (no, i wasn't aware of the "causes \
> real bugs" implication)
c) sounds like a very good idea. That will make the animations much more fluent :-) \
But more 4.9 material than 4.8
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103733/#review9947
-----------------------------------------------------------
On Jan. 19, 2012, 12:38 p.m., Philipp Knechtges wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103733/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2012, 12:38 p.m.)
>
>
> Review request for kwin, Thomas Lübking, Martin Gräßlin, and Fredrik Höglund.
>
>
> Description
> -------
>
> In some unfortunate situations it is possible that a window is deleted
> before it is marked ready_for_painting=true. The last point is
> especially troublesome for effects that reference the deleted window.
>
>
> This addresses bugs 288948 and 290025.
> http://bugs.kde.org/show_bug.cgi?id=288948
> http://bugs.kde.org/show_bug.cgi?id=290025
>
>
> Diffs
> -----
>
> kwin/deleted.h 1f98aaf
> kwin/deleted.cpp f465159
>
> Diff: http://git.reviewboard.kde.org/r/103733/diff/diff
>
>
> Testing
> -------
>
> Fixes the high cpu usage bug, which I can reliably trigger with glide effect \
> enabled and starting amarok. This should definitely go into the 4.8 release.
>
>
> Thanks,
>
> Philipp Knechtges
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103733/">http://git.reviewboard.kde.org/r/103733/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 19th, 2012, 2:38 p.m., <b>Commit \
Hook</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
d07964e0af95911a97c3f474b694570cb279878c by Philipp Knechtges to branch \
KDE/4.8.</pre> </blockquote>
<p>On January 19th, 2012, 2:59 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a) Sorry for being late \
b) Good catch! c) While a securing mechanism is inevitable, the ultimate source of \
the issue is that we emit signals like esp "windowAdded" and \
"windowClosed" to windows not being ready for painting - what is a lie (the \
window doesn't appear or hide, and pre-sending "windowAdded" causes \
visual breaks of show animations. d) I knew there was sth. left i wanted to do before \
4.8... :-\ (no, i wasn't aware of the "causes real bugs" \
implication)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">c) sounds like a very \
good idea. That will make the animations much more fluent :-) But more 4.9 material \
than 4.8</pre> <br />
<p>- Martin</p>
<br />
<p>On January 19th, 2012, 12:38 p.m., Philipp Knechtges wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Thomas Lübking, Martin Gräßlin, and Fredrik \
Höglund.</div> <div>By Philipp Knechtges.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2012, 12:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In some unfortunate situations it is possible that a window is deleted \
before it is marked ready_for_painting=true. The last point is especially troublesome \
for effects that reference the deleted window.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes the high cpu usage bug, which I can reliably trigger with glide \
effect enabled and starting amarok. This should definitely go into the 4.8 \
release.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288948">288948</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=290025">290025</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/deleted.h <span style="color: grey">(1f98aaf)</span></li>
<li>kwin/deleted.cpp <span style="color: grey">(f465159)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103733/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic