From kwin Thu Jan 19 15:27:14 2012 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Thu, 19 Jan 2012 15:27:14 +0000 To: kwin Subject: Re: Review Request: fixing high cpu usage bugs Message-Id: <20120119152714.18335.47418 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=132698701919416 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3536819750138022416==" --===============3536819750138022416== Content-Type: multipart/alternative; boundary="===============7308273062065170537==" --===============7308273062065170537== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Jan. 19, 2012, 2:38 p.m., Commit Hook wrote: > > This review has been submitted with commit d07964e0af95911a97c3f474b694= 570cb279878c by Philipp Knechtges to branch KDE/4.8. > = > Thomas L=C3=BCbking wrote: > a) Sorry for being late > b) Good catch! > c) While a securing mechanism is inevitable, the ultimate source of t= he issue is that we emit signals like esp "windowAdded" and "windowClosed" = to windows not being ready for painting - what is a lie (the window doesn't= appear or hide, and pre-sending "windowAdded" causes visual breaks of show= animations. > d) I knew there was sth. left i wanted to do before 4.8... :-\ (no, i= wasn't aware of the "causes real bugs" implication) c) sounds like a very good idea. That will make the animations much more fl= uent :-) But more 4.9 material than 4.8 - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103733/#review9947 ----------------------------------------------------------- On Jan. 19, 2012, 12:38 p.m., Philipp Knechtges wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103733/ > ----------------------------------------------------------- > = > (Updated Jan. 19, 2012, 12:38 p.m.) > = > = > Review request for kwin, Thomas L=C3=BCbking, Martin Gr=C3=A4=C3=9Flin, a= nd Fredrik H=C3=B6glund. > = > = > Description > ------- > = > In some unfortunate situations it is possible that a window is deleted > before it is marked ready_for_painting=3Dtrue. The last point is > especially troublesome for effects that reference the deleted window. > = > = > This addresses bugs 288948 and 290025. > http://bugs.kde.org/show_bug.cgi?id=3D288948 > http://bugs.kde.org/show_bug.cgi?id=3D290025 > = > = > Diffs > ----- > = > kwin/deleted.h 1f98aaf = > kwin/deleted.cpp f465159 = > = > Diff: http://git.reviewboard.kde.org/r/103733/diff/diff > = > = > Testing > ------- > = > Fixes the high cpu usage bug, which I can reliably trigger with glide eff= ect enabled and starting amarok. > This should definitely go into the 4.8 release. > = > = > Thanks, > = > Philipp Knechtges > = > --===============7308273062065170537== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103733/

On January 19th, 2012, 2:38 p.m., Commit Ho= ok wrote:

This revi=
ew has been submitted with commit d07964e0af95911a97c3f474b694570cb279878c =
by Philipp Knechtges to branch KDE/4.8.

On January 19th, 2012, 2:59 p.m., Thomas L=C3=BCbking wrote:

a) Sorry =
for being late
b) Good catch!
c) While a securing mechanism is inevitable, the ultimate source of the iss=
ue is that we emit signals like esp "windowAdded" and "windo=
wClosed" to windows not being ready for painting - what is a lie (the =
window doesn't appear or hide, and pre-sending "windowAdded" =
causes visual breaks of show animations.
d) I knew there was sth. left i wanted to do before 4.8... :-\ (no, i wasn&=
#39;t aware of the "causes real bugs" implication)
c) sounds l=
ike a very good idea. That will make the animations much more fluent :-) Bu=
t more 4.9 material than 4.8

- Martin


On January 19th, 2012, 12:38 p.m., Philipp Knechtges wrote:

Review request for kwin, Thomas L=C3=BCbking, Martin Gr=C3=A4=C3=9Flin= , and Fredrik H=C3=B6glund.
By Philipp Knechtges.

Updated Jan. 19, 2012, 12:38 p.m.

Descripti= on 

In some unfortunate situations it is possible that a window =
is deleted
before it is marked ready_for_painting=3Dtrue. The last point is
especially troublesome for effects that reference the deleted window.

Testing <= /h1> 
Fixes the high cpu usage bug, which I can reliably trigger w=
ith glide effect enabled and starting amarok.
This should definitely go into the 4.8 release.
Bugs: 288948, = 290025

Diffs=

  • kwin/deleted.h (1f98aaf)
  • kwin/deleted.cpp (f465159)

View Diff
--===============7308273062065170537==-- --===============3536819750138022416== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============3536819750138022416==--