This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103733/

On January 19th, 2012, 2:38 p.m., Commit Hook wrote:

This review has been submitted with commit d07964e0af95911a97c3f474b694570cb279878c by Philipp Knechtges to branch KDE/4.8.

On January 19th, 2012, 2:59 p.m., Thomas Lübking wrote:

a) Sorry for being late
b) Good catch!
c) While a securing mechanism is inevitable, the ultimate source of the issue is that we emit signals like esp "windowAdded" and "windowClosed" to windows not being ready for painting - what is a lie (the window doesn't appear or hide, and pre-sending "windowAdded" causes visual breaks of show animations.
d) I knew there was sth. left i wanted to do before 4.8... :-\ (no, i wasn't aware of the "causes real bugs" implication)
c) sounds like a very good idea. That will make the animations much more fluent :-) But more 4.9 material than 4.8

- Martin


On January 19th, 2012, 12:38 p.m., Philipp Knechtges wrote:

Review request for kwin, Thomas Lübking, Martin Gräßlin, and Fredrik Höglund.
By Philipp Knechtges.

Updated Jan. 19, 2012, 12:38 p.m.

Description

In some unfortunate situations it is possible that a window is deleted
before it is marked ready_for_painting=true. The last point is
especially troublesome for effects that reference the deleted window.

Testing

Fixes the high cpu usage bug, which I can reliably trigger with glide effect enabled and starting amarok.
This should definitely go into the 4.8 release.
Bugs: 288948, 290025

Diffs

  • kwin/deleted.h (1f98aaf)
  • kwin/deleted.cpp (f465159)

View Diff