[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Aurorae goes QML
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-01-12 10:43:35
Message-ID: 20120112104335.2478.71655 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103670/
-----------------------------------------------------------
(Updated Jan. 12, 2012, 10:43 a.m.)
Review request for kwin and Marco Martin.
Changes
-------
* kcm ported to QML (makes the Aurorae previews interactive)
* changing themes works
* resizing at border works
* share declarative engine between decorations
* old code removed
Description
-------
QML rewrite of Aurorae with some elements which could become a decoration c=
omponents API. What's currently working:
* rendering of active/inactive backgrounds
* all buttons (including interaction)
* border/padding sizes
* captions
* nice transition between all possible states
What's currently not working:
* switching themes
* mouse wheel support on decoration (other mouse events are working). Will =
try using an event filter on the decoration.
* resize at borders
* window tabs
If you wonder why the old code is not removed: it's still used by the KCM.
@notmart: please have a look at the QML code. I'm still learning :-)
Diffs (updated)
-----
kwin/clients/aurorae/src/CMakeLists.txt fcc2d20 =
kwin/clients/aurorae/src/aurorae.h f920533 =
kwin/clients/aurorae/src/aurorae.cpp f6d59ca =
kwin/clients/aurorae/src/lib/auroraebutton.h cc1f1f2 =
kwin/clients/aurorae/src/lib/auroraebutton.cpp 1f54a90 =
kwin/clients/aurorae/src/lib/auroraescene.h c0548c1 =
kwin/clients/aurorae/src/lib/auroraescene.cpp 597dde1 =
kwin/clients/aurorae/src/lib/auroraetab.h b5104f8 =
kwin/clients/aurorae/src/lib/auroraetab.cpp d903de3 =
kwin/clients/aurorae/src/lib/auroraetheme.h 70b662f =
kwin/clients/aurorae/src/lib/auroraetheme.cpp 8b62865 =
kwin/clients/aurorae/src/qml/AuroraeButton.qml PRE-CREATION =
kwin/clients/aurorae/src/qml/AuroraeButtonGroup.qml PRE-CREATION =
kwin/clients/aurorae/src/qml/AuroraeMaximizeButton.qml PRE-CREATION =
kwin/clients/aurorae/src/qml/Decoration.qml PRE-CREATION =
kwin/clients/aurorae/src/qml/DecorationButton.qml PRE-CREATION =
kwin/clients/aurorae/src/qml/MenuButton.qml PRE-CREATION =
kwin/clients/aurorae/src/qml/aurorae.qml PRE-CREATION =
kwin/kcmkwin/kwindecoration/CMakeLists.txt 6a7c536 =
kwin/kcmkwin/kwindecoration/decoration.ui eb694d9 =
kwin/kcmkwin/kwindecoration/decorationdelegate.h e849d9f =
kwin/kcmkwin/kwindecoration/decorationdelegate.cpp d0712de =
kwin/kcmkwin/kwindecoration/decorationmodel.h d3a7057 =
kwin/kcmkwin/kwindecoration/decorationmodel.cpp d211dc4 =
kwin/kcmkwin/kwindecoration/kwindecoration.h 6ef19c0 =
kwin/kcmkwin/kwindecoration/kwindecoration.cpp 3042305 =
kwin/kcmkwin/kwindecoration/qml/AuroraeDecoration.qml PRE-CREATION =
kwin/kcmkwin/kwindecoration/qml/main.qml PRE-CREATION =
Diff: http://git.reviewboard.kde.org/r/103670/diff/diff
Testing
-------
Thanks,
Martin Gr=C3=A4=C3=9Flin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103670/">http://git.reviewboard.kde.org/r/103670/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Marco Martin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2012, 10:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* kcm ported to QML (makes the Aurorae previews \
interactive)
* changing themes works
* resizing at border works
* share declarative engine between decorations
* old code removed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QML rewrite of Aurorae with some elements which could become a \
decoration components API. What's currently working:
* rendering of active/inactive backgrounds
* all buttons (including interaction)
* border/padding sizes
* captions
* nice transition between all possible states
What's currently not working:
* switching themes
* mouse wheel support on decoration (other mouse events are working). Will try using \
an event filter on the decoration.
* resize at borders
* window tabs
If you wonder why the old code is not removed: it's still used by the KCM.
@notmart: please have a look at the QML code. I'm still learning :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/aurorae/src/CMakeLists.txt <span style="color: \
grey">(fcc2d20)</span></li>
<li>kwin/clients/aurorae/src/aurorae.h <span style="color: \
grey">(f920533)</span></li>
<li>kwin/clients/aurorae/src/aurorae.cpp <span style="color: \
grey">(f6d59ca)</span></li>
<li>kwin/clients/aurorae/src/lib/auroraebutton.h <span style="color: \
grey">(cc1f1f2)</span></li>
<li>kwin/clients/aurorae/src/lib/auroraebutton.cpp <span style="color: \
grey">(1f54a90)</span></li>
<li>kwin/clients/aurorae/src/lib/auroraescene.h <span style="color: \
grey">(c0548c1)</span></li>
<li>kwin/clients/aurorae/src/lib/auroraescene.cpp <span style="color: \
grey">(597dde1)</span></li>
<li>kwin/clients/aurorae/src/lib/auroraetab.h <span style="color: \
grey">(b5104f8)</span></li>
<li>kwin/clients/aurorae/src/lib/auroraetab.cpp <span style="color: \
grey">(d903de3)</span></li>
<li>kwin/clients/aurorae/src/lib/auroraetheme.h <span style="color: \
grey">(70b662f)</span></li>
<li>kwin/clients/aurorae/src/lib/auroraetheme.cpp <span style="color: \
grey">(8b62865)</span></li>
<li>kwin/clients/aurorae/src/qml/AuroraeButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/qml/AuroraeButtonGroup.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/qml/AuroraeMaximizeButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/qml/Decoration.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/qml/DecorationButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/qml/MenuButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/qml/aurorae.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/kcmkwin/kwindecoration/CMakeLists.txt <span style="color: \
grey">(6a7c536)</span></li>
<li>kwin/kcmkwin/kwindecoration/decoration.ui <span style="color: \
grey">(eb694d9)</span></li>
<li>kwin/kcmkwin/kwindecoration/decorationdelegate.h <span style="color: \
grey">(e849d9f)</span></li>
<li>kwin/kcmkwin/kwindecoration/decorationdelegate.cpp <span style="color: \
grey">(d0712de)</span></li>
<li>kwin/kcmkwin/kwindecoration/decorationmodel.h <span style="color: \
grey">(d3a7057)</span></li>
<li>kwin/kcmkwin/kwindecoration/decorationmodel.cpp <span style="color: \
grey">(d211dc4)</span></li>
<li>kwin/kcmkwin/kwindecoration/kwindecoration.h <span style="color: \
grey">(6ef19c0)</span></li>
<li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(3042305)</span></li>
<li>kwin/kcmkwin/kwindecoration/qml/AuroraeDecoration.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/kcmkwin/kwindecoration/qml/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103670/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic