[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request: Rank rules above motif
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-01-12 17:11:28
Message-ID: 20120112171128.28865.9332 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103681/
-----------------------------------------------------------
Review request for kwin and Martin Gräßlin.
Description
-------
Turns out KDE/Qt application re-yell "have a border" every now and then whenever they \
feel like. The patch
a) ensures that clients may change their opinion, but yelling "MAKE BORDER" over and \
over again, overriding the users (temp. eg. alt+f3 or apply initially rule) is \
ignored b) honors rules when applying motif hints (this alone would only cover the \
"force" rules)
This addresses bug 291312.
http://bugs.kde.org/show_bug.cgi?id=291312
Diffs
-----
kwin/client.cpp 8c00249
Diff: http://git.reviewboard.kde.org/r/103681/diff/diff
Testing
-------
No, I just sensed this would be the issue and happily assume it will work... :-P
Thanks,
Thomas Lübking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103681/">http://git.reviewboard.kde.org/r/103681/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Turns out KDE/Qt application re-yell "have a border" every now \
and then whenever they feel like. The patch
a) ensures that clients may change their opinion, but yelling "MAKE BORDER" \
over and over again, overriding the users (temp. eg. alt+f3 or apply initially rule) \
is ignored b) honors rules when applying motif hints (this alone would only cover the \
"force" rules)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No, I just sensed this would be the issue and happily assume it will \
work... :-P</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291312">291312</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(8c00249)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103681/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic