This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103670/

Review request for kwin and Marco Martin.
By Martin Gräßlin.

Updated Jan. 12, 2012, 10:43 a.m.

Changes

* kcm ported to QML (makes the Aurorae previews interactive)
* changing themes works
* resizing at border works
* share declarative engine between decorations
* old code removed

Description

QML rewrite of Aurorae with some elements which could become a decoration components API. What's currently working:
* rendering of active/inactive backgrounds
* all buttons (including interaction)
* border/padding sizes
* captions
* nice transition between all possible states

What's currently not working:
* switching themes
* mouse wheel support on decoration (other mouse events are working). Will try using an event filter on the decoration.
* resize at borders
* window tabs

If you wonder why the old code is not removed: it's still used by the KCM.

@notmart: please have a look at the QML code. I'm still learning :-)

Diffs (updated)

  • kwin/clients/aurorae/src/CMakeLists.txt (fcc2d20)
  • kwin/clients/aurorae/src/aurorae.h (f920533)
  • kwin/clients/aurorae/src/aurorae.cpp (f6d59ca)
  • kwin/clients/aurorae/src/lib/auroraebutton.h (cc1f1f2)
  • kwin/clients/aurorae/src/lib/auroraebutton.cpp (1f54a90)
  • kwin/clients/aurorae/src/lib/auroraescene.h (c0548c1)
  • kwin/clients/aurorae/src/lib/auroraescene.cpp (597dde1)
  • kwin/clients/aurorae/src/lib/auroraetab.h (b5104f8)
  • kwin/clients/aurorae/src/lib/auroraetab.cpp (d903de3)
  • kwin/clients/aurorae/src/lib/auroraetheme.h (70b662f)
  • kwin/clients/aurorae/src/lib/auroraetheme.cpp (8b62865)
  • kwin/clients/aurorae/src/qml/AuroraeButton.qml (PRE-CREATION)
  • kwin/clients/aurorae/src/qml/AuroraeButtonGroup.qml (PRE-CREATION)
  • kwin/clients/aurorae/src/qml/AuroraeMaximizeButton.qml (PRE-CREATION)
  • kwin/clients/aurorae/src/qml/Decoration.qml (PRE-CREATION)
  • kwin/clients/aurorae/src/qml/DecorationButton.qml (PRE-CREATION)
  • kwin/clients/aurorae/src/qml/MenuButton.qml (PRE-CREATION)
  • kwin/clients/aurorae/src/qml/aurorae.qml (PRE-CREATION)
  • kwin/kcmkwin/kwindecoration/CMakeLists.txt (6a7c536)
  • kwin/kcmkwin/kwindecoration/decoration.ui (eb694d9)
  • kwin/kcmkwin/kwindecoration/decorationdelegate.h (e849d9f)
  • kwin/kcmkwin/kwindecoration/decorationdelegate.cpp (d0712de)
  • kwin/kcmkwin/kwindecoration/decorationmodel.h (d3a7057)
  • kwin/kcmkwin/kwindecoration/decorationmodel.cpp (d211dc4)
  • kwin/kcmkwin/kwindecoration/kwindecoration.h (6ef19c0)
  • kwin/kcmkwin/kwindecoration/kwindecoration.cpp (3042305)
  • kwin/kcmkwin/kwindecoration/qml/AuroraeDecoration.qml (PRE-CREATION)
  • kwin/kcmkwin/kwindecoration/qml/main.qml (PRE-CREATION)

View Diff