'Re: Review Request: simplifying paintSimpleScreen'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: simplifying paintSimpleScreen
From:       "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date:       2012-01-10 20:37:02
Message-ID: 20120110203702.8392.11707 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103671/
-----------------------------------------------------------

(Updated Jan. 10, 2012, 8:37 p.m.)

Review request for kwin.

Changes
-------

* removing PAINT_DECORATION_ONLY
* substituting QHash for QList < QPair <....> >

Description
-------

This patch reduces the number of QRegion and WindowQuadList operations
by drawing the opaque and translucent parts of the window within the
same bottom to top pass.

One could also consider removing PAINT_DECORATION_ONLY. Opinions on that?

Diffs (updated)
-----

  kwin/libkwineffects/kwineffects.h 780cc89 =

  kwin/scene.h d8bcf48 =

  kwin/scene.cpp 82935c2 =

  kwin/scene_opengl.cpp d85e393 =

  kwin/scene_xrender.cpp f76cf70 =

Diff: http://git.reviewboard.kde.org/r/103671/diff/diff

Testing
-------

works :)

Thanks,

Philipp Knechtges

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103671/">http://git.reviewboard.kde.org/r/103671/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated Jan. 10, 2012, 8:37 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* removing PAINT_DECORATION_ONLY
* substituting QHash for QList &lt; QPair &lt;....&gt; &gt;</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch reduces the number of QRegion and WindowQuadList operations \
by drawing the opaque and translucent parts of the window within the same bottom to \
top pass.

One could also consider removing PAINT_DECORATION_ONLY. Opinions on that?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(780cc89)</span></li>

 <li>kwin/scene.h <span style="color: grey">(d8bcf48)</span></li>

 <li>kwin/scene.cpp <span style="color: grey">(82935c2)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: grey">(d85e393)</span></li>

 <li>kwin/scene_xrender.cpp <span style="color: grey">(f76cf70)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103671/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 