'Re: Review Request: simplifying paintSimpleScreen'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: simplifying paintSimpleScreen
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-01-10 19:34:37
Message-ID: 20120110193437.4516.20762 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103671/#review9721
-----------------------------------------------------------

I guess since the first pass is actually no pass, one could probably simply build \
phase2data as QList< QPair<Window*, Phase2Data> > in stack order, and than just \
iterate it in both passes. Spares us the expensive hash adding and the lookups.
Also this: " if (data == phase2data.end())" causes a "detach()" (ie. copy) of the \
phase2data each and every time ...

- Thomas Lübking

On Jan. 10, 2012, 6:42 p.m., Philipp Knechtges wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103671/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2012, 6:42 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> This patch reduces the number of QRegion and WindowQuadList operations
> by drawing the opaque and translucent parts of the window within the
> same bottom to top pass.
> 
> One could also consider removing PAINT_DECORATION_ONLY. Opinions on that?
> 
> 
> Diffs
> -----
> 
> kwin/scene.h d8bcf48609afca160836acb2993def908fcdc467 
> kwin/scene.cpp 82935c2e900f18aa6f959befcb116253a3b8fdf6 
> 
> Diff: http://git.reviewboard.kde.org/r/103671/diff/diff
> 
> 
> Testing
> -------
> 
> works :)
> 
> 
> Thanks,
> 
> Philipp Knechtges
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103671/">http://git.reviewboard.kde.org/r/103671/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess since the first \
pass is actually no pass, one could probably simply build phase2data as QList&lt; \
QPair&lt;Window*, Phase2Data&gt; &gt; in stack order, and than just iterate it in \
both passes. Spares us the expensive hash adding and the lookups.
Also this: &quot; if (data == phase2data.end())&quot; causes a &quot;detach()&quot; \
(ie. copy) of the phase2data each and every time ...</pre>  <br />

<p>- Thomas</p>

<br />
<p>On January 10th, 2012, 6:42 p.m., Philipp Knechtges wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated Jan. 10, 2012, 6:42 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch reduces the number of QRegion and WindowQuadList operations \
by drawing the opaque and translucent parts of the window within the same bottom to \
top pass.

One could also consider removing PAINT_DECORATION_ONLY. Opinions on that?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scene.h <span style="color: \
grey">(d8bcf48609afca160836acb2993def908fcdc467)</span></li>

 <li>kwin/scene.cpp <span style="color: \
grey">(82935c2e900f18aa6f959befcb116253a3b8fdf6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103671/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 