[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: simplifying paintSimpleScreen
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-01-10 21:01:54
Message-ID: 20120110210154.10133.73898 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103671/#review9730
-----------------------------------------------------------
kwin/libkwineffects/kwineffects.h
<http://git.reviewboard.kde.org/r/103671/#comment8035>
The enum is duplicated (for what reason ever) in scene.h - it should be=
dropped there as well.
- Martin Gr=C3=A4=C3=9Flin
On Jan. 10, 2012, 8:37 p.m., Philipp Knechtges wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103671/
> -----------------------------------------------------------
> =
> (Updated Jan. 10, 2012, 8:37 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> This patch reduces the number of QRegion and WindowQuadList operations
> by drawing the opaque and translucent parts of the window within the
> same bottom to top pass.
> =
> One could also consider removing PAINT_DECORATION_ONLY. Opinions on that?
> =
> =
> Diffs
> -----
> =
> kwin/libkwineffects/kwineffects.h 780cc89 =
> kwin/scene.h d8bcf48 =
> kwin/scene.cpp 82935c2 =
> kwin/scene_opengl.cpp d85e393 =
> kwin/scene_xrender.cpp f76cf70 =
> =
> Diff: http://git.reviewboard.kde.org/r/103671/diff/diff
> =
> =
> Testing
> -------
> =
> works :)
> =
> =
> Thanks,
> =
> Philipp Knechtges
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103671/">http://git.reviewboard.kde.org/r/103671/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103671/diff/2/?file=46396#file46396line316" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/libkwineffects/kwineffects.h</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">315</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * \
Temporary solution since (_OPAQUE | _TRANSLUCENT) is not working \
currently.</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">316</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> \
**/</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> <td \
bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; "></pre></td> </tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">317</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">PAINT_DECORATION_ONLY</span> <span class="o">=</span> <span \
class="mi">1</span> <span class="o"><<</span> <span class="mi">7</span><span \
class="p">,</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">318</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="cm">/**</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The enum is \
duplicated (for what reason ever) in scene.h - it should be dropped there as \
well.</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On January 10th, 2012, 8:37 p.m., Philipp Knechtges wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Philipp Knechtges.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2012, 8:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch reduces the number of QRegion and WindowQuadList operations \
by drawing the opaque and translucent parts of the window within the same bottom to \
top pass.
One could also consider removing PAINT_DECORATION_ONLY. Opinions on that?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(780cc89)</span></li>
<li>kwin/scene.h <span style="color: grey">(d8bcf48)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(82935c2)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(d85e393)</span></li>
<li>kwin/scene_xrender.cpp <span style="color: grey">(f76cf70)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103671/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic