'Re: Review Request: Optimize Fade Effect'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Optimize Fade Effect
From:       "Commit Hook" <null () kde ! org>
Date:       2011-08-29 5:12:44
Message-ID: 20110829051244.19672.38883 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102452/#review6119
-----------------------------------------------------------

This review has been submitted with commit 1c49cb9e649a7644cab4c93e4590d71e=
834ad8c4 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit

On Aug. 27, 2011, 11:24 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102452/
> -----------------------------------------------------------
> =

> (Updated Aug. 27, 2011, 11:24 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Summary
> -------
> =

> After doing the Effect::isActive() change I noticed that Fade Effect is a=
lways active. That's because the Windows are kept in the hash and only get =
removed when the window is deleted. This changes to remove them also after =
the fadeIn animation. Removes another hot codepath showing in callgrind as =
the operator[] is not the fastest and often used in paintWindow.
> =

> =

> Diffs
> -----
> =

>   kwin/effects/fade/fade.cpp 52f0e37 =

> =

> Diff: http://git.reviewboard.kde.org/r/102452/diff
> =

> =

> Testing
> -------
> =

> FadeIn works, fadeOut works
> =

> =

> Thanks,
> =

> Martin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102452/">http://git.reviewboard.kde.org/r/102452/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 1c49cb9e649a7644cab4c93e4590d71e834ad8c4 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 27th, 2011, 11:24 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 27, 2011, 11:24 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After doing the Effect::isActive() change I noticed that Fade Effect is \
always active. That&#39;s because the Windows are kept in the hash and only get \
removed when the window is deleted. This changes to remove them also after the fadeIn \
animation. Removes another hot codepath showing in callgrind as the operator[] is not \
the fastest and often used in paintWindow.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">FadeIn works, fadeOut works</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/fade/fade.cpp <span style="color: grey">(52f0e37)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102452/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 