This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102452/ 

This review has been submitted with commit 1c49cb9e649a7644cab4c93e4590d71e834ad8c4 by Martin Gräßlin to branch master.

- Commit


On August 27th, 2011, 11:24 a.m., Martin Gräßlin wrote:

Review request for kwin.
By Martin Gräßlin.

Updated Aug. 27, 2011, 11:24 a.m.

Description 

After doing the Effect::isActive() change I noticed that Fade Effect is always active. That's because the Windows are kept in the hash and only get removed when the window is deleted. This changes to remove them also after the fadeIn animation. Removes another hot codepath showing in callgrind as the operator[] is not the fastest and often used in paintWindow.

Testing 

FadeIn works, fadeOut works

Diffs

  • kwin/effects/fade/fade.cpp (52f0e37)

View Diff