From kwin Mon Aug 29 05:12:44 2011 From: "Commit Hook" Date: Mon, 29 Aug 2011 05:12:44 +0000 To: kwin Subject: Re: Review Request: Optimize Fade Effect Message-Id: <20110829051244.19672.38883 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=131459478519533 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6560060646144247021==" --===============6560060646144247021== Content-Type: multipart/alternative; boundary="===============0636460679238275066==" --===============0636460679238275066== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102452/#review6119 ----------------------------------------------------------- This review has been submitted with commit 1c49cb9e649a7644cab4c93e4590d71e= 834ad8c4 by Martin Gr=C3=A4=C3=9Flin to branch master. - Commit On Aug. 27, 2011, 11:24 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102452/ > ----------------------------------------------------------- > = > (Updated Aug. 27, 2011, 11:24 a.m.) > = > = > Review request for kwin. > = > = > Summary > ------- > = > After doing the Effect::isActive() change I noticed that Fade Effect is a= lways active. That's because the Windows are kept in the hash and only get = removed when the window is deleted. This changes to remove them also after = the fadeIn animation. Removes another hot codepath showing in callgrind as = the operator[] is not the fastest and often used in paintWindow. > = > = > Diffs > ----- > = > kwin/effects/fade/fade.cpp 52f0e37 = > = > Diff: http://git.reviewboard.kde.org/r/102452/diff > = > = > Testing > ------- > = > FadeIn works, fadeOut works > = > = > Thanks, > = > Martin > = > --===============0636460679238275066== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102452/

This revie=
w has been submitted with commit 1c49cb9e649a7644cab4c93e4590d71e834ad8c4 b=
y Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit

On August 27th, 2011, 11:24 a.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.

By Martin Gr=C3=A4=C3=9Flin.

Updated Aug. 27, 2011, 11:24 a.m.

Descripti= on

After doing the Effect::isActive() change I noticed that Fad=
e Effect is always active. That's because the Windows are kept in the h=
ash and only get removed when the window is deleted. This changes to remove=
 them also after the fadeIn animation. Removes another hot codepath showing=
 in callgrind as the operator[] is not the fastest and often used in paintW=
indow.

Testing <= /h1>

FadeIn works, fadeOut works

Diffs=

kwin/effects/fade/fade.cpp (52f0e37)

View Diff

--===============0636460679238275066==-- --===============6560060646144247021== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============6560060646144247021==--