'Re: Review Request: Change compositing timers to QElapsedTimers'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Change compositing timers to QElapsedTimers
From:       "Commit Hook" <null () kde ! org>
Date:       2011-08-29 4:48:57
Message-ID: 20110829044857.18259.58824 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102473/#review6113
-----------------------------------------------------------

This review has been submitted with commit 5fa175e15f80cb8cbe0ea7818902ea04=
87616a66 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit

On Aug. 28, 2011, 9:12 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102473/
> -----------------------------------------------------------
> =

> (Updated Aug. 28, 2011, 9:12 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Summary
> -------
> =

> Mostly a review request for Thomas, as he touched the code last :-) Inste=
ad of calculating the elapsed time from epoch clock, using a QElapsedTimer =
as well as reusing the timer object instead of creating a new one in the sc=
ene each frame.
> =

> =

> Diffs
> -----
> =

>   kwin/composite.cpp 7257bb6 =

>   kwin/scene.h 6ce39c0 =

>   kwin/scene_opengl_egl.cpp 4e232c2 =

>   kwin/scene_opengl_glx.cpp 43f522c =

>   kwin/scene_xrender.cpp 73dd22f =

>   kwin/workspace.h 2cba848 =

> =

> Diff: http://git.reviewboard.kde.org/r/102473/diff
> =

> =

> Testing
> -------
> =

> No issues noticed while using.
> =

> =

> Thanks,
> =

> Martin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102473/">http://git.reviewboard.kde.org/r/102473/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5fa175e15f80cb8cbe0ea7818902ea0487616a66 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 28th, 2011, 9:12 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 28, 2011, 9:12 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Mostly a review request for Thomas, as he touched the code last :-) \
Instead of calculating the elapsed time from epoch clock, using a QElapsedTimer as \
well as reusing the timer object instead of creating a new one in the scene each \
frame.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No issues noticed while using.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.cpp <span style="color: grey">(7257bb6)</span></li>

 <li>kwin/scene.h <span style="color: grey">(6ce39c0)</span></li>

 <li>kwin/scene_opengl_egl.cpp <span style="color: grey">(4e232c2)</span></li>

 <li>kwin/scene_opengl_glx.cpp <span style="color: grey">(43f522c)</span></li>

 <li>kwin/scene_xrender.cpp <span style="color: grey">(73dd22f)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(2cba848)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102473/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 