--===============5979763985230612702== Content-Type: multipart/alternative; boundary="===============8613990663241945133==" --===============8613990663241945133== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102473/#review6113 ----------------------------------------------------------- This review has been submitted with commit 5fa175e15f80cb8cbe0ea7818902ea04= 87616a66 by Martin Gr=C3=A4=C3=9Flin to branch master. - Commit On Aug. 28, 2011, 9:12 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102473/ > ----------------------------------------------------------- > = > (Updated Aug. 28, 2011, 9:12 a.m.) > = > = > Review request for kwin. > = > = > Summary > ------- > = > Mostly a review request for Thomas, as he touched the code last :-) Inste= ad of calculating the elapsed time from epoch clock, using a QElapsedTimer = as well as reusing the timer object instead of creating a new one in the sc= ene each frame. > = > = > Diffs > ----- > = > kwin/composite.cpp 7257bb6 = > kwin/scene.h 6ce39c0 = > kwin/scene_opengl_egl.cpp 4e232c2 = > kwin/scene_opengl_glx.cpp 43f522c = > kwin/scene_xrender.cpp 73dd22f = > kwin/workspace.h 2cba848 = > = > Diff: http://git.reviewboard.kde.org/r/102473/diff > = > = > Testing > ------- > = > No issues noticed while using. > = > = > Thanks, > = > Martin > = > --===============8613990663241945133== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102473/

This revie=
w has been submitted with commit 5fa175e15f80cb8cbe0ea7818902ea0487616a66 b=
y Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit


On August 28th, 2011, 9:12 a.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.

Updated Aug. 28, 2011, 9:12 a.m.

Descripti= on

Mostly a review request for Thomas, as he touched the code l=
ast :-) Instead of calculating the elapsed time from epoch clock, using a Q=
ElapsedTimer as well as reusing the timer object instead of creating a new =
one in the scene each frame.

Testing <= /h1>
No issues noticed while using.

Diffs=

  • kwin/composite.cpp (7257bb6)
  • kwin/scene.h (6ce39c0)
  • kwin/scene_opengl_egl.cpp (4e232c2)=
  • kwin/scene_opengl_glx.cpp (43f522c)=
  • kwin/scene_xrender.cpp (73dd22f)
  • kwin/workspace.h (2cba848)

View Diff

--===============8613990663241945133==-- --===============5979763985230612702== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============5979763985230612702==--