[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: tabstrip win deco: make outline color configurable
From: "Melchior Franz" <mfranz () kde ! org>
Date: 2011-08-27 18:21:32
Message-ID: 20110827182132.9693.67314 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 27, 2011, 4:13 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > I don't mind much about Tabstrip. As I don't expect the original author=
to comment on it :-( and what I see looks fine, I give you a shipit.
> > =
> > Thanks for the patch and it's always nice seeing someone improve the ha=
rdly maintained decorations :-)
Thanks, committed.
https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revi=
sions/09c152aca0735cb7791bb7369714c184699ac955
- Melchior
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102438/#review6065
-----------------------------------------------------------
On Aug. 26, 2011, 1:44 p.m., Melchior Franz wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102438/
> -----------------------------------------------------------
> =
> (Updated Aug. 26, 2011, 1:44 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Summary
> -------
> =
> In addition to the black background frame and the colored titlebar the "t=
abstrip" window decoration also has an outline, which is currently hard-cod=
ed as white. This doesn't fit very well in certain color combinations, espe=
cially in dark setups, so it is desirable to make this color configurable. =
The idea has been ACK'ed by the tabstrip authors (Jorge MATA: "I think it w=
ould be a good idea to have a color chooser in the decoration configuration=
for this setting." and Lucas MURRAY: "Lovely").
> =
> The config dialog (attached screenshot) isn't particularly pleasing, but =
I found it hard to align the three different widgets in a meaningful way. T=
he first screenshot shows the deco with grouped windows and black as outlin=
e color. You can see that the title bar composition doesn't become unclear =
if the outline is invisible, even in grouped mode. The second screenshot sh=
ows windows with different combinations copied together as an illustration.=
The top row corresponds to the currently hardcoded outline color white.
> =
> =
> Diffs
> -----
> =
> kwin/clients/tabstrip/config/tabstripconfig.cpp 4174cba =
> kwin/clients/tabstrip/config/tabstripconfig.ui 1a21e05 =
> kwin/clients/tabstrip/tabstripdecoration.cpp ae46872 =
> kwin/clients/tabstrip/tabstripfactory.h 2b667f0 =
> kwin/clients/tabstrip/tabstripfactory.cpp 591a148 =
> =
> Diff: http://git.reviewboard.kde.org/r/102438/diff
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> black outline
> http://git.reviewboard.kde.org/r/102438/s/241/
> white (default), green, olive outline
> http://git.reviewboard.kde.org/r/102438/s/242/
> config
> http://git.reviewboard.kde.org/r/102438/s/243/
> =
> =
> Thanks,
> =
> Melchior
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102438/">http://git.reviewboard.kde.org/r/102438/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 27th, 2011, 4:13 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I don't mind much about Tabstrip. As I don't expect the original \
author to comment on it :-( and what I see looks fine, I give you a shipit.
Thanks for the patch and it's always nice seeing someone improve the hardly \
maintained decorations :-)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, committed.
https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revisions/09c152aca0735cb7791bb7369714c184699ac955
</pre>
<br />
<p>- Melchior</p>
<br />
<p>On August 26th, 2011, 1:44 p.m., Melchior Franz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Melchior Franz.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2011, 1:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In addition to the black background frame and the colored titlebar the \
"tabstrip" window decoration also has an outline, which is currently \
hard-coded as white. This doesn't fit very well in certain color combinations, \
especially in dark setups, so it is desirable to make this color configurable. The \
idea has been ACK'ed by the tabstrip authors (Jorge MATA: "I think it would \
be a good idea to have a color chooser in the decoration configuration for this \
setting." and Lucas MURRAY: "Lovely").
The config dialog (attached screenshot) isn't particularly pleasing, but I found \
it hard to align the three different widgets in a meaningful way. The first \
screenshot shows the deco with grouped windows and black as outline color. You can \
see that the title bar composition doesn't become unclear if the outline is \
invisible, even in grouped mode. The second screenshot shows windows with different \
combinations copied together as an illustration. The top row corresponds to the \
currently hardcoded outline color white.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/tabstrip/config/tabstripconfig.cpp <span style="color: \
grey">(4174cba)</span></li>
<li>kwin/clients/tabstrip/config/tabstripconfig.ui <span style="color: \
grey">(1a21e05)</span></li>
<li>kwin/clients/tabstrip/tabstripdecoration.cpp <span style="color: \
grey">(ae46872)</span></li>
<li>kwin/clients/tabstrip/tabstripfactory.h <span style="color: \
grey">(2b667f0)</span></li>
<li>kwin/clients/tabstrip/tabstripfactory.cpp <span style="color: \
grey">(591a148)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102438/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102438/s/241/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/25/tabstrip_400x100.png" \
style="border: 1px black solid;" alt="black outline" /></a>
<a href="http://git.reviewboard.kde.org/r/102438/s/242/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/25/tabstrip2_400x100.png" \
style="border: 1px black solid;" alt="white (default), green, olive outline" /></a>
<a href="http://git.reviewboard.kde.org/r/102438/s/243/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/25/config_400x100.jpg" \
style="border: 1px black solid;" alt="config" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic